From: Sebastian Andrzej Siewior <bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
To: Grant Likely <grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [RFC] OF: make of_property_for_each_u32() use parameters if OF is not enabled
Date: Mon, 17 Jun 2013 08:59:34 +0200 [thread overview]
Message-ID: <51BEB3D6.4090307@linutronix.de> (raw)
In-Reply-To: <20130615140018.572793E0A2E@localhost>
On 06/15/2013 04:00 PM, Grant Likely wrote:
>> --- a/include/linux/of.h
>> +++ b/include/linux/of.h
>> @@ -507,8 +507,8 @@ static inline int of_machine_is_compatible(const char *compat)
>>
>> #define of_match_ptr(_ptr) NULL
>> #define of_match_node(_matches, _node) NULL
>> -#define of_property_for_each_u32(np, propname, prop, p, u) \
>> - while (0)
>> +#define of_property_for_each_u32(np, propname, prop, p, u) \
>
> Unrelated whitespace change
>
>> + for (prop = NULL, p = NULL; 0; prop++, p++)
>
> The prop++ and p++ bits should be dropped. It would probably be better
The ++ ensure that gcc does spit a "set but not used warning".
> to move the of_property_for_each_* macros outside the #ifdef/#else block
> and have an empty definition of of_prop_next_string/of_prop_next_u32.
so let me look at that.
>
> g.
>
Sebastian
next prev parent reply other threads:[~2013-06-17 6:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-13 15:28 [RFC] OF: make of_property_for_each_u32() use parameters if OF is not enabled Sebastian Andrzej Siewior
[not found] ` <1371137331-4652-1-git-send-email-bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2013-06-15 14:00 ` Grant Likely
2013-06-17 6:59 ` Sebastian Andrzej Siewior [this message]
2013-06-17 14:48 ` [PATCH v2] OF: make of_property_for_each_{u32|string}() " Sebastian Andrzej Siewior
[not found] ` <20130617144813.GA10582-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2013-07-20 5:28 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51BEB3D6.4090307@linutronix.de \
--to=bigeasy-hfztesqfncyowbw4kg4ksq@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).