From mboxrd@z Thu Jan 1 00:00:00 1970 From: boris brezillon Subject: Re: [RFC PATCH 0/4] watchdog: at91sam9_wdt: handle already configured wdt Date: Fri, 21 Jun 2013 08:59:41 +0200 Message-ID: <51C3F9DD.5040709@overkiz.com> References: <1370947890-954-1-git-send-email-b.brezillon@overkiz.com> Mime-Version: 1.0 Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: "Yang, Wenyou" Cc: Wim Van Sebroeck , Jean-Christophe Plagniol-Villard , "Ferre, Nicolas" , "linux-watchdog@vger.kernel.org" , "devicetree-discuss@lists.ozlabs.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org On 21/06/2013 03:47, Yang, Wenyou wrote: > >> -----Original Message----- >> From: linux-arm-kernel [mailto:linux-arm-kernel-bounces@lists.infrad= ead.org] >> On Behalf Of Boris BREZILLON >> Sent: 2013=C4=EA6=D4=C211=C8=D5 18:51 >> To: Wim Van Sebroeck; Jean-Christophe Plagniol-Villard; Ferre, Nicol= as; >> linux-watchdog@vger.kernel.org >> Cc: devicetree-discuss@lists.ozlabs.org; linux-doc@vger.kernel.org; >> linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; = Boris >> BREZILLON >> Subject: [RFC PATCH 0/4] watchdog: at91sam9_wdt: handle already conf= igured >> wdt >> >> Hello, >> >> This patch series is a porposal to enhance the sam9 watchdog timer s= upport. >> >> The at91sam9 watchdog timer cannot configured twice, and the current >> implementation only tries to configure in a static way: >> - 2 seconds timeout >> - wdt restart every 500ms >> >> If the timer has already been configured with different values, it r= eturns an >> error and do not create any watchdog device. >> >> This is not critical if the watchdog is disabled, but if it has been= enabled with >> different timeout values it will lead to a SoC reset. >> >> This patch series tries to address this issue by adapting the heartb= eat value >> according the WDT timer config: >> - it first tries to configure the timer as requested. >> - if it fails it fallbacks to the current config, adapting its heart= beat timer >> to the needs >> >> This patch series also move to a dynamically allocated at91wdt devic= e instead >> of the static instance. I'm not sure this is the best solution, so p= lease tell >> me if you prefer to keep static instance of watchdog. >> >> It adds a new at91 wdt type: software. This new type make use of the= at91 wdt >> interrupt to trigger a software watchdog. >> >> Finally it adds several properties to the device tree bindings. >> >> Best Regards, >> Boris >> >> Boris BREZILLON (4): >> watchdog: at91sam9_wdt: better watchdog support >> watchdog: at91sam9_wdt: update device tree doc >> ARM: at91/dt: add sam9 watchdog default options to SoCs >> ARM: at91/dt: add watchdog properties to kizbox board >> >> .../devicetree/bindings/watchdog/atmel-wdt.txt | 30 +- >> arch/arm/boot/dts/at91sam9260.dtsi | 5 + >> arch/arm/boot/dts/at91sam9263.dtsi | 5 + >> arch/arm/boot/dts/at91sam9g45.dtsi | 5 + >> arch/arm/boot/dts/at91sam9n12.dtsi | 5 + >> arch/arm/boot/dts/at91sam9x5.dtsi | 5 + >> arch/arm/boot/dts/kizbox.dts | 6 + >> arch/arm/boot/dts/sama5d3.dtsi | 5 + >> drivers/watchdog/at91sam9_wdt.c | 319 >> +++++++++++++++----- >> 9 files changed, 300 insertions(+), 85 deletions(-) >> >> -- >> 1.7.9.5 >> >> > Tested on sama5d34ek, at91sam9g25ek, linux-next_20130620 > > Tested by Wenyou Yang > Thanks for your tests and review. Best Regards, Boris >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel