From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: linux-kernel@vger.kernel.org, Vineet Gupta <vgupta@synopsys.com>,
Russell King <linux@arm.linux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Mark Salter <msalter@redhat.com>,
Aurelien Jacquiot <a-jacquiot@ti.com>,
James Hogan <james.hogan@imgtec.com>,
Michal Simek <monstr@monstr.eu>,
Ralf Baechle <ralf@linux-mips.org>,
Jonas Bonn <jonas@southpole.se>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
x86@kernel.org, arm@kernel.org, Chris Zankel <chris@zankel.net>,
Max Filippov <jcmvbkbc@gmail.com>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <rob.herring@calxeda.com>,
robherring2@gmail.com, Nicolas Pitre <nicolas.pitre@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-c6x-dev@linux-c6x.org, linux-mips@linux-mips.org,
linuxppc-dev@lists.ozlabs.org, linux-xtensa@linux-xtensa.
Subject: Re: [PATCH] of: Specify initrd location using 64-bit
Date: Fri, 21 Jun 2013 11:04:28 +0200 [thread overview]
Message-ID: <51C4171C.9050908@linutronix.de> (raw)
In-Reply-To: <1371775956-16453-1-git-send-email-santosh.shilimkar@ti.com>
On 06/21/2013 02:52 AM, Santosh Shilimkar wrote:
> diff --git a/arch/microblaze/kernel/prom.c b/arch/microblaze/kernel/prom.c
> index 0a2c68f..62e2e8f 100644
> --- a/arch/microblaze/kernel/prom.c
> +++ b/arch/microblaze/kernel/prom.c
> @@ -136,8 +136,7 @@ void __init early_init_devtree(void *params)
> }
>
> #ifdef CONFIG_BLK_DEV_INITRD
> -void __init early_init_dt_setup_initrd_arch(unsigned long start,
> - unsigned long end)
> +void __init early_init_dt_setup_initrd_arch(u64 start, u64 end)
> {
> initrd_start = (unsigned long)__va(start);
> initrd_end = (unsigned long)__va(end);
I think it would better to go here for phys_addr_t instead of u64. This
would force you in of_flat_dt_match() to check if the value passed from
DT specifies a memory address outside of 32bit address space and the
kernel can't deal with this because its phys_addr_t is 32bit only due
to a Kconfig switch.
For x86, the initrd has to remain in the 32bit address space so passing
the initrd in the upper range would violate the ABI. Not sure if this
is true for other archs as well (ARM obviously not).
Sebastian
next prev parent reply other threads:[~2013-06-21 9:04 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-21 0:52 [PATCH] of: Specify initrd location using 64-bit Santosh Shilimkar
2013-06-21 4:39 ` Vineet Gupta
2013-06-21 8:23 ` James Hogan
2013-06-21 17:12 ` Santosh Shilimkar
2013-06-21 9:04 ` Sebastian Andrzej Siewior [this message]
2013-06-21 17:20 ` Santosh Shilimkar
2013-06-27 20:54 ` Rob Herring
2013-06-28 7:54 ` Sebastian Andrzej Siewior
[not found] ` <51CCA67C.2010803-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-06-28 9:59 ` Grant Likely
[not found] ` <CACxGe6vOH0sCFVVXrYqD3dbYdOvithVu7-d1cvy5885i8x_Myw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-06-28 13:49 ` Jean-Christophe PLAGNIOL-VILLARD
2013-06-28 23:43 ` Santosh Shilimkar
2013-06-29 8:34 ` Geert Uytterhoeven
[not found] ` <51CE1F92.3070802-l0cyMroinI0@public.gmane.org>
2013-07-01 7:48 ` Sebastian Andrzej Siewior
2013-07-01 7:59 ` Geert Uytterhoeven
2013-07-01 8:09 ` Sebastian Andrzej Siewior
2013-07-01 13:58 ` Santosh Shilimkar
-- strict thread matches above, loose matches on Subject: below --
2012-09-12 16:05 [PATCH] of: specify " Cyril Chemparathy
2012-09-12 16:16 ` Geert Uytterhoeven
2012-09-12 18:02 ` Cyril Chemparathy
2012-09-12 19:58 ` Sebastian Andrzej Siewior
2012-09-12 22:08 ` Rob Herring
2012-09-13 6:47 ` Sebastian Andrzej Siewior
2012-09-13 21:02 ` Rob Herring
2012-09-12 20:23 ` Rob Herring
2012-09-12 20:31 ` Nicolas Pitre
2012-09-12 20:56 ` Rob Herring
2012-09-12 23:45 ` Cyril Chemparathy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C4171C.9050908@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=a-jacquiot@ti.com \
--cc=arm@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=catalin.marinas@arm.com \
--cc=chris@zankel.net \
--cc=grant.likely@linaro.org \
--cc=james.hogan@imgtec.com \
--cc=jcmvbkbc@gmail.com \
--cc=jonas@southpole.se \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-c6x-dev@linux-c6x.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-xtensa@linux-xtensa. \
--cc=linux@arm.linux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=monstr@monstr.eu \
--cc=msalter@redhat.com \
--cc=nicolas.pitre@linaro.org \
--cc=paulus@samba.org \
--cc=ralf@linux-mips.org \
--cc=rob.herring@calxeda.com \
--cc=robherring2@gmail.com \
--cc=santosh.shilimkar@ti.com \
--cc=vgupta@synopsys.com \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).