devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Laxman Dewangan <ldewangan@nvidia.com>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: "broonie@kernel.org" <broonie@kernel.org>,
	"grant.likely@linaro.org" <grant.likely@linaro.org>,
	"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
	"rob@landley.net" <rob@landley.net>,
	"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
	Stephen Warren <swarren@nvidia.com>,
	"gg@slimlogic.co.uk" <gg@slimlogic.co.uk>,
	"sameo@linux.intel.com" <sameo@linux.intel.com>,
	"devicetree-discuss@lists.ozlabs.org"
	<devicetree-discuss@lists.ozlabs.org>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] regulator: palmas: model SMPS10 as two regulators
Date: Fri, 21 Jun 2013 18:55:28 +0530	[thread overview]
Message-ID: <51C45448.4080201@nvidia.com> (raw)
In-Reply-To: <51C31F30.5000307@ti.com>

On Thursday 20 June 2013 08:56 PM, Kishon Vijay Abraham I wrote:
> Hi,
>
> On Thursday 20 June 2013 08:14 PM, Laxman Dewangan wrote:
>>
>> Have you added the regulator supply entries?
>> Are you testing on mainline linux-next?
> Not in linux-next :-( Tested only with mainline.
> Does inverting the order helps?
>

I think because you do not have entry of supply in your dt node, it gets 
ignored by regulator_dev_lookup() and continue.

I made the entry like (added entry form smps10-out2-supply and 
smps10-in-supply in dt node) and then it failed.
/***

+                           smps10-out2-supply = <&palmas_smps10_out2_reg>;
+                           smps10-in-supply = <&tps65090_dcdc3_reg>;
                             ldo3-in-supply = <&palmas_smps3_reg>;
@@ -903,6 +905,20 @@
                                         regulator-always-on;
                                 };

+                               palmas_smps10_out1_reg: smps10_out1 {
+                                       regulator-name = "smps10_out1";
+                                       regulator-min-microvolt = <5000000>;
+                                       regulator-max-microvolt = <5000000>;
+                                       regulator-always-on;
+                               };
+
+                               palmas_smps10_out2_reg: smps10_out2 {
+                                       regulator-name = "smps10_out2";
+                                       regulator-min-microvolt = <5000000>;
+                                       regulator-max-microvolt = <5000000>;
+                                       regulator-always-on;
+                               };
+
**/


After reversing the sequence, it worked fine.


  reply	other threads:[~2013-06-21 13:25 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-20  8:37 [PATCH 0/2] Model SMPS10 regulator Kishon Vijay Abraham I
     [not found] ` <1371717458-10307-1-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2013-06-20  8:37   ` [PATCH 1/2] regulator: of: Added a property to indicate bypass mode support Kishon Vijay Abraham I
     [not found]     ` <1371717458-10307-2-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2013-06-20 11:20       ` Mark Brown
2013-06-20  8:37   ` [PATCH 2/2] regulator: palmas: model SMPS10 as two regulators Kishon Vijay Abraham I
2013-06-20 10:52     ` Laxman Dewangan
     [not found]       ` <51C2DEEB.9090600-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-06-20 13:50         ` Kishon Vijay Abraham I
2013-06-20 14:03           ` Laxman Dewangan
     [not found]             ` <51C30B95.4010406-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-06-20 14:19               ` Kishon Vijay Abraham I
     [not found]                 ` <51C30F60.3060100-l0cyMroinI0@public.gmane.org>
2013-06-20 14:44                   ` Laxman Dewangan
2013-06-20 15:26                     ` Kishon Vijay Abraham I
2013-06-21 13:25                       ` Laxman Dewangan [this message]
     [not found]                         ` <51C45448.4080201-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-06-21 14:00                           ` Kishon Vijay Abraham I
2013-06-22 13:12                             ` Laxman Dewangan
     [not found]                               ` <51C5A2BC.5060401-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-06-24  5:23                                 ` Kishon Vijay Abraham I

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51C45448.4080201@nvidia.com \
    --to=ldewangan@nvidia.com \
    --cc=broonie@kernel.org \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=gg@slimlogic.co.uk \
    --cc=grant.likely@linaro.org \
    --cc=kishon@ti.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rob.herring@calxeda.com \
    --cc=rob@landley.net \
    --cc=sameo@linux.intel.com \
    --cc=swarren@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).