From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH v5] clocksource:arm_global_timer: Add ARM global timer support. Date: Mon, 24 Jun 2013 13:06:32 -0700 Message-ID: <51C8A6C8.8000009@codeaurora.org> References: <1372089195-29219-1-git-send-email-srinivas.kandagatla@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1372089195-29219-1-git-send-email-srinivas.kandagatla@st.com> Sender: linux-doc-owner@vger.kernel.org To: Srinivas KANDAGATLA Cc: John Stultz , Thomas Gleixner , Grant Likely , Rob Herring , Rob Landley , devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Linus Walleij , Stuart Menefy , Arnd Bergmann , Rob Herring , Will Deacon List-Id: devicetree@vger.kernel.org On 06/24/13 08:53, Srinivas KANDAGATLA wrote: > + > +static void gt_clockevents_stop(struct clock_event_device *clk) > +{ > + gt_clockevent_set_mode(CLOCK_EVT_MODE_UNUSED, clk); > + disable_percpu_irq(clk->irq); > +} > + > +static int __cpuinit gt_clockevents_setup(struct clock_event_device *clk) > +{ > + struct clock_event_device *evt = this_cpu_ptr(gt_evt); > + return evt->name ? 0 : gt_clockevents_init(evt); > +} How does this work? gt_clockevents_stop() is using the clock_event_device struct from the ARM local timer layer whereas gt_clockevents_setup() is using a driver private allocation. Please just don't use the local timer API at all and use cpu notifiers instead. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation