* [PATCH -next] video: mxsfb: remove redundant dev_err call in mxsfb_probe()
@ 2013-06-26 1:50 Wei Yongjun
[not found] ` <CAPgLHd80wMDBg8ADjtDvZC1=yUoigS7_btHMz1=r8WQTwpgSvg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2013-06-26 1:50 UTC (permalink / raw)
To: plagnioj-sclMFOaUSTBWk0Htik3J/w, tomi.valkeinen-l0cyMroinI0,
grant.likely-QSEj5FYQhm4dnm+yROfE0A,
rob.herring-bsGFqQB8/DxBDgjK7y7TUQ
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ,
yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY,
linux-fbdev-u79uwXL29TY76Z2rM5mHXA
From: Wei Yongjun <yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org>
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Signed-off-by: Wei Yongjun <yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org>
---
drivers/video/mxsfb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c
index 21223d4..251bbec 100644
--- a/drivers/video/mxsfb.c
+++ b/drivers/video/mxsfb.c
@@ -899,7 +899,6 @@ static int mxsfb_probe(struct platform_device *pdev)
host->base = devm_ioremap_resource(&pdev->dev, res);
if (IS_ERR(host->base)) {
- dev_err(&pdev->dev, "ioremap failed\n");
ret = PTR_ERR(host->base);
goto fb_release;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread[parent not found: <CAPgLHd80wMDBg8ADjtDvZC1=yUoigS7_btHMz1=r8WQTwpgSvg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH -next] video: mxsfb: remove redundant dev_err call in mxsfb_probe() [not found] ` <CAPgLHd80wMDBg8ADjtDvZC1=yUoigS7_btHMz1=r8WQTwpgSvg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2013-06-26 11:43 ` Tomi Valkeinen 0 siblings, 0 replies; 2+ messages in thread From: Tomi Valkeinen @ 2013-06-26 11:43 UTC (permalink / raw) To: Wei Yongjun Cc: linux-fbdev-u79uwXL29TY76Z2rM5mHXA, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ, rob.herring-bsGFqQB8/DxBDgjK7y7TUQ, yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY, grant.likely-QSEj5FYQhm4dnm+yROfE0A [-- Attachment #1.1: Type: text/plain, Size: 934 bytes --] On 26/06/13 04:50, Wei Yongjun wrote: > From: Wei Yongjun <yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org> > > There is a error message within devm_ioremap_resource > already, so remove the dev_err call to avoid redundant > error message. > > Signed-off-by: Wei Yongjun <yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org> > --- > drivers/video/mxsfb.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c > index 21223d4..251bbec 100644 > --- a/drivers/video/mxsfb.c > +++ b/drivers/video/mxsfb.c > @@ -899,7 +899,6 @@ static int mxsfb_probe(struct platform_device *pdev) > > host->base = devm_ioremap_resource(&pdev->dev, res); > if (IS_ERR(host->base)) { > - dev_err(&pdev->dev, "ioremap failed\n"); > ret = PTR_ERR(host->base); > goto fb_release; > } > I've added this to my fbdev-3.11 branch. Tomi [-- Attachment #1.2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 901 bytes --] [-- Attachment #2: Type: text/plain, Size: 192 bytes --] _______________________________________________ devicetree-discuss mailing list devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org https://lists.ozlabs.org/listinfo/devicetree-discuss ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-06-26 11:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-26 1:50 [PATCH -next] video: mxsfb: remove redundant dev_err call in mxsfb_probe() Wei Yongjun
[not found] ` <CAPgLHd80wMDBg8ADjtDvZC1=yUoigS7_btHMz1=r8WQTwpgSvg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-06-26 11:43 ` Tomi Valkeinen
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).