From: Tero Kristo <t-kristo@ti.com>
To: balbi@ti.com
Cc: linux-omap@vger.kernel.org, paul@pwsan.com, tony@atomide.com,
mturquette@linaro.org, nm@ti.com, rnayak@ti.com,
linux-arm-kernel@lists.infradead.org,
devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH 2/4] ARM: OMAP5: clockdomain data: add init file for omap54xx
Date: Thu, 27 Jun 2013 12:24:25 +0300 [thread overview]
Message-ID: <51CC04C9.3050801@ti.com> (raw)
In-Reply-To: <20130627084434.GT15455@arwen.pp.htv.fi>
On 06/27/2013 11:44 AM, Felipe Balbi wrote:
> Hi,
>
> On Thu, Jun 27, 2013 at 11:38:17AM +0300, Tero Kristo wrote:
>> + rc = clk_set_parent(abe_dpll_ref, sys_32k_ck);
>> + abe_dpll = clk_get_sys(NULL, "dpll_abe_ck");
>
> should these two lines be swaped ?
No, its a different clock. clk_set_parent is done for a clock that is a
parent of dpll_abe_ck.
>
>> + if (!rc)
>> + rc = clk_set_rate(abe_dpll, OMAP5_DPLL_ABE_DEFFREQ);
>> + if (rc)
>> + pr_err("%s: failed to configure ABE DPLL!\n", __func__);
>> +
>> + return 0;
>
> so even if (rc) you still return 0 ? Shouldn't you return rc instead ?
Hmm yea, this could be improved. :) Same should be done for O4 / DRA7
also. Seems like a long lasting feature actually.
-Tero
next prev parent reply other threads:[~2013-06-27 9:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 8:38 [PATCH 0/4] ARM: OMAP5 and DRA7 clock data Tero Kristo
2013-06-27 8:38 ` [PATCH 1/4] ARM: dts: omap5 " Tero Kristo
2013-06-27 8:38 ` [PATCH 2/4] ARM: OMAP5: clockdomain data: add init file for omap54xx Tero Kristo
2013-06-27 8:44 ` Felipe Balbi
2013-06-27 9:24 ` Tero Kristo [this message]
2013-06-27 10:06 ` Felipe Balbi
2013-06-28 21:03 ` Mike Turquette
2013-07-08 7:28 ` Tero Kristo
2013-06-27 8:38 ` [PATCH 3/4] ARM: dts: dra7xx clock data Tero Kristo
2013-06-27 8:38 ` [PATCH 4/4] ARM: DRA7: clockdomain data: add init file for dra7 Tero Kristo
2013-06-28 21:04 ` Mike Turquette
2013-07-08 7:29 ` Tero Kristo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51CC04C9.3050801@ti.com \
--to=t-kristo@ti.com \
--cc=balbi@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=nm@ti.com \
--cc=paul@pwsan.com \
--cc=rnayak@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).