From: Sekhar Nori <nsekhar@ti.com>
To: Luciano Coelho <coelho@ti.com>
Cc: mark.rutland@arm.com, nm@ti.com, mturquette@linaro.org,
linux-doc@vger.kernel.org, tony@atomide.com,
devicetree-discuss@lists.ozlabs.org,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
balbi@ti.com, rob.herring@calxeda.com, grant.likely@linaro.org,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 2/8] wlcore: set irq_flags in the board files instead of hiding behind a quirk
Date: Thu, 4 Jul 2013 10:16:24 +0530 [thread overview]
Message-ID: <51D4FE20.6000805@ti.com> (raw)
In-Reply-To: <1372860209-3504-3-git-send-email-coelho@ti.com>
On 7/3/2013 7:33 PM, Luciano Coelho wrote:
> The platform_quirk element in the platform data was used to change the
> way the IRQ is triggered. When set, the EDGE_IRQ quirk would change
> the irqflags used and treat edge trigger differently from the rest.
>
> Instead of hiding this irq flag setting behind the quirk, have the
> board files set the flags during initialization. This will be more
> meaningful than driver-specific quirks when we switch to DT.
>
> Additionally, fix missing gpio_request() calls in the boarding files
> (so that setting the flags actually works).
>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Sekhar Nori <nsekhar@ti.com>
> Signed-off-by: Luciano Coelho <coelho@ti.com>
> ---
> arch/arm/mach-davinci/board-da850-evm.c | 8 +++++-
For the board-da850-evm.c change,
Acked-by: Sekhar Nori <nsekhar@ti.com>
Thanks,
Sekhar
next prev parent reply other threads:[~2013-07-04 4:46 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-03 14:03 [PATCH v3 0/8] wilink: add device tree support Luciano Coelho
[not found] ` <1372860209-3504-1-git-send-email-coelho-l0cyMroinI0@public.gmane.org>
2013-07-03 14:03 ` [PATCH v3 1/8] wl1251: split wl251 platform data to a separate structure Luciano Coelho
[not found] ` <1372860209-3504-2-git-send-email-coelho-l0cyMroinI0@public.gmane.org>
2013-07-03 14:11 ` Felipe Balbi
2013-07-03 14:03 ` [PATCH v3 2/8] wlcore: set irq_flags in the board files instead of hiding behind a quirk Luciano Coelho
2013-07-03 14:13 ` Felipe Balbi
2013-07-03 14:18 ` Luciano Coelho
[not found] ` <1372861094.21065.118.camel-eHkr6bJ9aPyyenC2BZ5AVw@public.gmane.org>
2013-07-03 14:23 ` Felipe Balbi
2013-07-03 14:15 ` Luciano Coelho
2013-07-03 15:12 ` Javier Martinez Canillas
2013-07-04 14:21 ` Luciano Coelho
2013-07-04 4:46 ` Sekhar Nori [this message]
2013-07-03 14:03 ` [PATCH v3 3/8] wlcore: remove pwr_in_suspend from platform data Luciano Coelho
2013-07-03 14:14 ` Felipe Balbi
2013-07-03 14:03 ` [PATCH v3 4/8] wl12xx: use frequency instead of enumerations for pdata clocks Luciano Coelho
[not found] ` <1372860209-3504-5-git-send-email-coelho-l0cyMroinI0@public.gmane.org>
2013-07-03 14:16 ` Felipe Balbi
2013-07-03 14:03 ` [PATCH v3 5/8] wlcore: add initial device tree support to the sdio module Luciano Coelho
2013-07-03 14:18 ` Felipe Balbi
2013-07-03 14:03 ` [PATCH v3 6/8] wlcore: sdio: add wilink clock providers Luciano Coelho
2013-07-03 14:03 ` [PATCH v3 7/8] wlcore: sdio: get clocks from device tree Luciano Coelho
2013-07-03 14:03 ` [PATCH v3 8/8] wlcore/wl12xx: check if we got correct clock data from DT Luciano Coelho
2013-07-03 14:19 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D4FE20.6000805@ti.com \
--to=nsekhar@ti.com \
--cc=balbi@ti.com \
--cc=coelho@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@linaro.org \
--cc=nm@ti.com \
--cc=rob.herring@calxeda.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).