From: Laxman Dewangan <ldewangan@nvidia.com>
To: Chanwoo Choi <cw00.choi@samsung.com>
Cc: "myungjoo.ham@samsung.com" <myungjoo.ham@samsung.com>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
"rob@landley.net" <rob@landley.net>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kishon@ti.com" <kishon@ti.com>,
"gg@slimlogic.co.uk" <gg@slimlogic.co.uk>
Subject: Re: [PATCH V2 2/4] extcon: palmas: enable ID_GND and ID_FLOAT detection always
Date: Wed, 10 Jul 2013 12:46:15 +0530 [thread overview]
Message-ID: <51DD0A3F.4080206@nvidia.com> (raw)
In-Reply-To: <51DD0707.8010400@samsung.com>
On Wednesday 10 July 2013 12:32 PM, Chanwoo Choi wrote:
> Hi Laxman,
>
>> @@ -84,28 +86,23 @@ static irqreturn_t palmas_id_irq_handler(int irq, void *_palmas_usb)
>>
>> if (set & PALMAS_USB_ID_INT_SRC_ID_GND) {
>> palmas_write(palmas_usb->palmas, PALMAS_USB_OTG_BASE,
>> - PALMAS_USB_ID_INT_EN_HI_SET,
>> - PALMAS_USB_ID_INT_EN_HI_SET_ID_FLOAT);
>> - palmas_write(palmas_usb->palmas, PALMAS_USB_OTG_BASE,
>> - PALMAS_USB_ID_INT_EN_HI_CLR,
>> - PALMAS_USB_ID_INT_EN_HI_CLR_ID_GND);
>> - palmas_write(palmas_usb->palmas, PALMAS_USB_OTG_BASE,
>> PALMAS_USB_ID_INT_LATCH_CLR,
>> PALMAS_USB_ID_INT_EN_HI_CLR_ID_GND);
>> palmas_usb->linkstat = PALMAS_USB_STATE_ID;
>> extcon_set_cable_state(&palmas_usb->edev, "USB-HOST", true);
>> + dev_info(palmas_usb->dev, "HOST cable is attached\n");
>> } else if (set & PALMAS_USB_ID_INT_SRC_ID_FLOAT) {
>> palmas_write(palmas_usb->palmas, PALMAS_USB_OTG_BASE,
>> - PALMAS_USB_ID_INT_EN_HI_SET,
>> - PALMAS_USB_ID_INT_EN_HI_SET_ID_GND);
>> - palmas_write(palmas_usb->palmas, PALMAS_USB_OTG_BASE,
>> - PALMAS_USB_ID_INT_EN_HI_CLR,
>> - PALMAS_USB_ID_INT_EN_HI_CLR_ID_FLOAT);
>> - palmas_write(palmas_usb->palmas, PALMAS_USB_OTG_BASE,
>> PALMAS_USB_ID_INT_LATCH_CLR,
>> PALMAS_USB_ID_INT_EN_HI_CLR_ID_FLOAT);
>> palmas_usb->linkstat = PALMAS_USB_STATE_DISCONNECT;
>> extcon_set_cable_state(&palmas_usb->edev, "USB-HOST", false);
>> + dev_info(palmas_usb->dev, "HOST cable is detached\n");
>> + } else if ((palmas_usb->linkstat == PALMAS_USB_STATE_ID) &&
>> + (!(set & PALMAS_USB_ID_INT_SRC_ID_GND))) {
>> + palmas_usb->linkstat = PALMAS_USB_STATE_DISCONNECT;
>> + extcon_set_cable_state(&palmas_usb->edev, "USB-HOST", false);
>> + dev_info(palmas_usb->dev, "HOST cable is detached\n");
>> }
> After I modify info message when USB-HOST cable is attached or detached
> as following mesesage, I applied this patch.
>
> "HOST cable is ..." -> "USB-HOST cable is"
Thank you very much for correction and more meaningful message.
Thanks,
Laxman
next prev parent reply other threads:[~2013-07-10 7:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-10 6:15 [PATCH V2 0/4] extcon: palmas: clean-up/fixes and suspend/resume susupport Laxman Dewangan
[not found] ` <1373436959-32444-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-07-10 6:15 ` [PATCH V2 1/4] extcon: palmas: remove unused member from palams_usb structure Laxman Dewangan
2013-07-10 6:15 ` [PATCH V2 2/4] extcon: palmas: enable ID_GND and ID_FLOAT detection always Laxman Dewangan
2013-07-10 7:02 ` Chanwoo Choi
2013-07-10 7:16 ` Laxman Dewangan [this message]
2013-07-10 6:15 ` [PATCH V2 3/4] extcon: palams: add support for suspend/resume Laxman Dewangan
2013-07-10 6:15 ` [PATCH V2 4/4] extcon: palmas: Option to disable ID/VBUS detection based on platform Laxman Dewangan
2013-07-10 6:55 ` Chanwoo Choi
2013-07-10 7:13 ` Laxman Dewangan
2013-07-10 7:34 ` Chanwoo Choi
2013-07-10 8:42 ` Laxman Dewangan
2013-07-10 6:57 ` [PATCH V2 0/4] extcon: palmas: clean-up/fixes and suspend/resume susupport Chanwoo Choi
2013-07-10 7:14 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51DD0A3F.4080206@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=gg@slimlogic.co.uk \
--cc=kishon@ti.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=rob@landley.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).