From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Jackson Subject: Re: [PATCHv2] am33xx: cpsw: default to ethernet hwaddr from efuse if not defined in dt Date: Fri, 12 Jul 2013 15:33:59 +0100 Message-ID: <51E013D7.7060301@newflow.co.uk> References: <1358461134-13452-1-git-send-email-jacmet@sunsite.dk> <50F8DA3A.3090406@ti.com> <51DAB39C.7090106@newflow.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <51DAB39C.7090106@newflow.co.uk> Sender: netdev-owner@vger.kernel.org To: Mugunthan V N Cc: Peter Korsgaard , linux-omap@vger.kernel.org, netdev@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, hvaibhav@ti.com, richardcochran@gmail.com, tony@atomide.com, michal.bachraty@gmail.com, michal.bachraty@streamunlimited.com List-Id: devicetree@vger.kernel.org On 08/07/13 13:42, Mark Jackson wrote: > On 18/01/13 05:14, Mugunthan V N wrote: >> On 1/18/2013 3:48 AM, Peter Korsgaard wrote: >>> When booting with CONFIG_ARM_APPENDED_DTB (either because of using an old >>> U-Boot, not wanting the hassle of 2 files or when using Falcon fast boot >>> mode in U-Boot), nothing updates the ethernet hwaddr specified for the >>> CPSW slaves, causing the driver to use a random hwaddr, which is some times >>> troublesome. >>> >>> The am33xx has unique ethernet hwaddrs programmed in the efuse, so it makes >>> more sense to default to these rather than random ones. Add a fixup step >>> which adds mac-address dt properties using the efuse addresses if the DTB >>> didn't contain valid ones. >>> >>> Signed-off-by: Peter Korsgaard >>> >> >> This implementation looks fine. >> Acked-by: Mugunthan V N > > Tested-by: Mark Jackson Is this ever going to be put into the mainline code ?