From: Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
To: "Kozaruk, Oleksandr" <oleksandr.kozaruk-l0cyMroinI0@public.gmane.org>
Cc: "tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org"
<tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>,
"benoit.cousson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org"
<benoit.cousson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
"Nayak, Rajendra" <rnayak-l0cyMroinI0@public.gmane.org>,
"Ujfalusi, Peter" <peter.ujfalusi-l0cyMroinI0@public.gmane.org>,
"ABRAHAM, KISHON VIJAY" <kishon-l0cyMroinI0@public.gmane.org>,
"jic23-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org"
<jic23-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>,
"grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org"
<grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
"rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org"
<rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
"sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org"
<sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
"ch.naveen-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org"
<ch.naveen-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
"poeschel-Xtl8qvBWbHwb1SvskN2V4Q@public.gmane.org"
<poeschel-Xtl8qvBWbHwb1SvskN2V4Q@public.gmane.org>,
"Kim, Milo" <Milo.Kim-l0cyMroinI0@public.gmane.org>,
"Krishnamoorthy,
Balaji T" <balajitk-l0cyMroinI0@public.gmane.org>,
"gg-kDsPt+C1G03kYMGBc/C6ZA@public.gmane.org"
<gg-kDsPt+C1G03kYMGBc/C6ZA@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org"
<devicetree-dis>
Subject: Re: [PATCH v3 2/2] iio: twl6030-gpadc: TWL6030, TWL6032 GPADC driver
Date: Mon, 15 Jul 2013 13:33:53 +0200 [thread overview]
Message-ID: <51E3DE21.9060105@metafoo.de> (raw)
In-Reply-To: <2A7ABDFCE21540479A5AEB0244A684D5E3D067-bXo5r3zvlxeIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
On 07/15/2013 01:09 PM, Kozaruk, Oleksandr wrote:
[...]
>
>>> + ret = devm_request_threaded_irq(dev, irq, NULL,
>>> + twl6030_gpadc_irq_handler,
>>> + IRQF_ONESHOT, "twl6030_gpadc", gpadc);
>>
>> You access memory in the interrupt handler which is freed before the interrupt
>> handler is freed.
> Thanks for pointing this. devm_* will free memory for irq after the driver
> is removed and memory for the device is freed. I took me awhile to understand
> this. Is there going to be something like devm_iio_device_alloc? whould it be helpfull?
>
Yes, I think it certainly makes sense to add a devm_iio_device_alloc(), care
to send a patch?
next prev parent reply other threads:[~2013-07-15 11:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-12 7:18 [PATCH v3 0/2] TWL6030, TWL6032 GPADC driver Oleksandr Kozaruk
2013-07-12 7:18 ` [PATCH v3 1/2] ARM: dts: twl: Add GPADC data to device tree Oleksandr Kozaruk
2013-07-12 7:18 ` [PATCH v3 2/2] iio: twl6030-gpadc: TWL6030, TWL6032 GPADC driver Oleksandr Kozaruk
[not found] ` <1373613482-28390-3-git-send-email-oleksandr.kozaruk-l0cyMroinI0@public.gmane.org>
2013-07-12 19:42 ` Jonathan Cameron
[not found] ` <51E05C0B.5050009-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-07-15 13:30 ` Kozaruk, Oleksandr
2013-07-15 14:05 ` Graeme Gregory
2013-07-12 19:56 ` Lars-Peter Clausen
2013-07-15 11:09 ` Kozaruk, Oleksandr
[not found] ` <2A7ABDFCE21540479A5AEB0244A684D5E3D067-bXo5r3zvlxeIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2013-07-15 11:33 ` Lars-Peter Clausen [this message]
[not found] ` <51E3DE21.9060105-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
2013-07-17 13:45 ` Oleksandr Kozaruk
2013-07-17 14:47 ` Lars-Peter Clausen
[not found] ` <51E05F6C.1060506-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
2013-07-15 11:56 ` Grygorii Strashko
[not found] ` <51E3E362.6090903-l0cyMroinI0@public.gmane.org>
2013-07-15 12:33 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E3DE21.9060105@metafoo.de \
--to=lars-qo5elluwu/uelga04laivw@public.gmane.org \
--cc=Milo.Kim-l0cyMroinI0@public.gmane.org \
--cc=balajitk-l0cyMroinI0@public.gmane.org \
--cc=benoit.cousson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=ch.naveen-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=gg-kDsPt+C1G03kYMGBc/C6ZA@public.gmane.org \
--cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=jic23-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org \
--cc=kishon-l0cyMroinI0@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=oleksandr.kozaruk-l0cyMroinI0@public.gmane.org \
--cc=peter.ujfalusi-l0cyMroinI0@public.gmane.org \
--cc=poeschel-Xtl8qvBWbHwb1SvskN2V4Q@public.gmane.org \
--cc=rnayak-l0cyMroinI0@public.gmane.org \
--cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
--cc=sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).