From: Roger Quadros <rogerq@ti.com>
To: tony@atomide.com
Cc: Roger Quadros <rogerq@ti.com>,
benoit.cousson@linaro.org, linux-omap@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, "Balbi, Felipe" <balbi@ti.com>
Subject: Re: [PATCH v2 4/4] ARM: OMAP2+: Provide alias to USB PHY clock
Date: Mon, 15 Jul 2013 17:05:13 +0300 [thread overview]
Message-ID: <51E40199.9070906@ti.com> (raw)
In-Reply-To: <1371571487-14389-5-git-send-email-rogerq@ti.com>
Hi Tony,
On 06/18/2013 07:04 PM, Roger Quadros wrote:
> Till the OMAP clocks are correctly defined in device tree, use
> this temporary hack to provide clock alias to the USB PHY clocks.
>
> Without this, USB Host & Ethernet will not be functional with
> device tree boots on Panda and uEVM.
Looks like this one got missed out.
USB host no longer works on Panda with DT boot.
Could you please queue this for next 3.11-rc? Thanks.
cheers,
-roger
>
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> ---
> arch/arm/mach-omap2/board-generic.c | 23 ++++++++++++++++++++++-
> 1 files changed, 22 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-generic.c b/arch/arm/mach-omap2/board-generic.c
> index 88aa6b1..7428733 100644
> --- a/arch/arm/mach-omap2/board-generic.c
> +++ b/arch/arm/mach-omap2/board-generic.c
> @@ -15,6 +15,7 @@
> #include <linux/of_irq.h>
> #include <linux/of_platform.h>
> #include <linux/irqdomain.h>
> +#include <linux/clk.h>
>
> #include <asm/mach/arch.h>
>
> @@ -35,6 +36,21 @@ static struct of_device_id omap_dt_match_table[] __initdata = {
> { }
> };
>
> +/*
> + * Create alias for USB host PHY clock.
> + * Remove this when clock phandle can be provided via DT
> + */
> +static void __init legacy_init_ehci_clk(char *clkname)
> +{
> + int ret;
> +
> + ret = clk_add_alias("main_clk", NULL, clkname, NULL);
> + if (ret) {
> + pr_err("%s:Failed to add main_clk alias to %s :%d\n",
> + __func__, clkname, ret);
> + }
> +}
> +
> static void __init omap_generic_init(void)
> {
> omap_sdrc_init(NULL, NULL);
> @@ -45,10 +61,15 @@ static void __init omap_generic_init(void)
> * HACK: call display setup code for selected boards to enable omapdss.
> * This will be removed when omapdss supports DT.
> */
> - if (of_machine_is_compatible("ti,omap4-panda"))
> + if (of_machine_is_compatible("ti,omap4-panda")) {
> omap4_panda_display_init_of();
> + legacy_init_ehci_clk("auxclk3_ck");
> +
> + }
> else if (of_machine_is_compatible("ti,omap4-sdp"))
> omap_4430sdp_display_init_of();
> + else if (of_machine_is_compatible("ti,omap5-uevm"))
> + legacy_init_ehci_clk("auxclk1_ck");
> }
>
> #ifdef CONFIG_SOC_OMAP2420
>
next prev parent reply other threads:[~2013-07-15 14:05 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-18 16:04 [PATCH v2 0/4] ARM: OMAP2+: Panda USB Host support and DVI EDID fix Roger Quadros
[not found] ` <1371571487-14389-1-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2013-06-18 16:04 ` [PATCH v2 1/4] ARM: dts: omap4-panda: Add USB Host support Roger Quadros
2013-06-19 1:17 ` Benoit Cousson
2013-06-19 7:36 ` Roger Quadros
2013-06-19 7:46 ` Tony Lindgren
2013-06-19 10:10 ` Benoit Cousson
2013-06-19 11:03 ` Roger Quadros
2013-06-19 11:30 ` Benoit Cousson
2013-06-19 14:02 ` Roger Quadros
2013-06-19 12:05 ` Florian Vaussard
2013-06-19 12:23 ` Benoit Cousson
2013-06-19 12:32 ` Tony Lindgren
2013-06-19 14:05 ` Roger Quadros
[not found] ` <51C1BA8C.6000703-l0cyMroinI0@public.gmane.org>
2013-06-19 18:17 ` Benoit Cousson
2013-06-19 22:40 ` Benoit Cousson
2013-06-20 11:49 ` Roger Quadros
2013-06-19 12:27 ` Tony Lindgren
2013-06-19 12:34 ` Benoit Cousson
2013-06-19 12:44 ` Tony Lindgren
2013-06-18 16:04 ` [PATCH v2 2/4] ARM: dts: omap4-panda: Fix DVI EDID reads Roger Quadros
2013-06-18 16:04 ` [PATCH v2 3/4] ARM: dts: omap5-uevm: Provide USB Host PHY clock frequency Roger Quadros
2013-06-18 16:04 ` [PATCH v2 4/4] ARM: OMAP2+: Provide alias to USB PHY clock Roger Quadros
2013-07-15 14:05 ` Roger Quadros [this message]
2013-07-16 12:32 ` Tony Lindgren
2013-07-16 13:39 ` Roger Quadros
2013-07-16 13:43 ` Tony Lindgren
2013-07-16 13:12 ` Arend van Spriel
2013-07-16 13:18 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E40199.9070906@ti.com \
--to=rogerq@ti.com \
--cc=balbi@ti.com \
--cc=benoit.cousson@linaro.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).