From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH] of/irq: init struct resource to 0 in of_irq_to_resource() Date: Thu, 18 Jul 2013 21:49:27 -0500 Message-ID: <51E8A937.9030109@gmail.com> References: <1374143050-25848-1-git-send-email-bigeasy@linutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1374143050-25848-1-git-send-email-bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Sebastian Andrzej Siewior Cc: Grant Likely , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Rob Herring List-Id: devicetree@vger.kernel.org On 07/18/2013 05:24 AM, Sebastian Andrzej Siewior wrote: > It almost does not matter because most users use only the ->start member > of the struct. However if this struct is passed to a platform device > which is then added via platform_device_add() then the ->parent member is > also used. Most users don't use the resource struct at all. The ones that do, all seem to do a memset beforehand. So I think current behavior is correct. There are some occurrences that pass a resource in, but then don't actually use the resource. Those we should fix. Rob > > Signed-off-by: Sebastian Andrzej Siewior > --- > drivers/of/irq.c | 1 + > 1 file changed, 1 insearch/powerpc/sysdev/mv64x60_dev.crtion(+) > > diff --git a/drivers/of/irq.c b/drivers/of/irq.c > index a3c1c5a..e0a72fb 100644 > --- a/drivers/of/irq.c > +++ b/drivers/of/irq.c > @@ -345,6 +345,7 @@ int of_irq_to_resource(struct device_node *dev, int index, struct resource *r) > if (r && irq) { > const char *name = NULL; > > + memset(r, 0, sizeof(*r)); > /* > * Get optional "interrupts-names" property to add a name > * to the resource. >