devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Valentin <eduardo.valentin@ti.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Stephen Warren <swarren@wwwdotorg.org>,
	Eduardo Valentin <eduardo.valentin@ti.com>,
	Grant Likely <grant.likely@linaro.org>,
	Rob Herring <rob.herring@calxeda.com>,
	devicetree-discuss@lists.ozlabs.org, wni@nvidia.com,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	lm-sensors@lm-sensors.org, l.stach@pengutronix.de
Subject: Re: [lm-sensors] [RESEND PATCH V1 0/9] thermal: introduce DT thermal zone build
Date: Fri, 19 Jul 2013 09:03:43 -0400	[thread overview]
Message-ID: <51E9392F.8060604@ti.com> (raw)
In-Reply-To: <20130718212108.GC4110@roeck-us.net>

[-- Attachment #1: Type: text/plain, Size: 2553 bytes --]

On 18-07-2013 17:21, Guenter Roeck wrote:
> On Thu, Jul 18, 2013 at 11:18:05AM -0600, Stephen Warren wrote:
>> On 07/18/2013 07:53 AM, Eduardo Valentin wrote:
>>> Hello Guenter,
>>>
>>> On 17-07-2013 18:09, Guenter Roeck wrote:
>>>> On Wed, Jul 17, 2013 at 11:17:19AM -0400, Eduardo Valentin
>>>> wrote:
>>>>> Hello all,
>>>>>
>>>>> As you noticed, I am working in a way to represent thermal
>>>>> data using device tree [1]. Essentially, this should be a way
>>>>> to say what to do with a sensor and how to associate (cooling)
>>>>> actions with it.
>>>>>
>>>> Seems to me that goes way beyond the supposed scope of devicetree
>>>> data. Devicetree data is supposed to describe hardware, not its
>>>> configuration or use. This is clearly a use case.
>>>
>>> Thanks for rising your voice here. It is important to know what
>>> hwmon ppl think about this.
>>
>> I meant to find time to read Guenter's original email where he
>> initially objected to putting data into DT, and determine exactly what
>> was being objected to. I still haven't:-( However, the arguments that
>> Eduardo stated in his email do make sense to me; I agree that
>> temperature limits really are a description of HW. Details of which
>> cooling methods to invoke when certain temperature limits are reached
>> is also part of the HW/system design, and hence I would tend to agree
>> that they're appropriate to include in DT. Anyway, that's just my 2
>> cents on the matter:-)
> 
> Many systems have multiple profiles for various use cases (high performance,
> low power etc), and limits are different based on the use case. If that means
> you are going to have multiple devicetree variants based on the profile,

No, definitely this patch series is *not* about mapping multiples
profiles for various use cases on device tree! This series is about
mapping *hw thermal limits* on device tree.

> I would argue that you crossed the line. With thermal profiles it gets even more
> complicated, as those parameters may be played around with and changed
> multiple times to find the best settings to achieve optimal cooling.
> Does this describe hardware ? I don't think so, but, as I mentioned before,
> maybe I am wrong.


Again, this is about describing points and actions to avoid your hw
degradation. May be also useful to avoid end user harm.

This series is not about describing performance profiles.

> 
> Guenter
> 
> 


-- 
You have got to be excited about what you are doing. (L. Lamport)

Eduardo Valentin


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 295 bytes --]

  reply	other threads:[~2013-07-19 13:03 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-17 15:17 [RESEND PATCH V1 0/9] thermal: introduce DT thermal zone build Eduardo Valentin
2013-07-17 15:17 ` [RESEND PATCH V1 1/9] cpufreq: cpufreq-cpu0: add dt node parsing for 'needs-cooling' Eduardo Valentin
2013-07-25 23:28   ` Rafael J. Wysocki
2013-07-26 13:27     ` Eduardo Valentin
2013-07-17 15:17 ` [RESEND PATCH V1 2/9] thermal: hwmon: move hwmon support to single file Eduardo Valentin
2013-07-17 16:29   ` [lm-sensors] " R, Durgadoss
2013-07-17 15:17 ` [RESEND PATCH V1 3/9] thermal: thermal_core: allow binding with limits on bind_params Eduardo Valentin
2013-07-17 16:25   ` [lm-sensors] " R, Durgadoss
2013-07-17 15:17 ` [RESEND PATCH V1 4/9] arm: dts: flag omap4430 with needs-cooling for cpu node Eduardo Valentin
2013-07-17 15:17 ` [RESEND PATCH V1 5/9] thermal: introduce device tree parser Eduardo Valentin
2013-07-17 15:17 ` [RESEND PATCH V1 6/9] thermal: ti-soc-thermal: use thermal DT infrastructure Eduardo Valentin
2013-07-17 15:17 ` [RESEND PATCH V1 7/9] arm: dts: add omap4430 thermal data Eduardo Valentin
2013-07-17 15:17 ` [RESEND PATCH V1 8/9] hwmon: lm75: expose to thermal fw via DT nodes Eduardo Valentin
2013-07-18  5:33   ` Wei Ni
2013-07-18 13:12     ` Eduardo Valentin
2013-07-19  7:43       ` Wei Ni
2013-07-18  7:22   ` Guenter Roeck
2013-07-17 15:17 ` [RESEND PATCH V1 9/9] hwmon: tmp102: " Eduardo Valentin
2013-07-18  7:23   ` Guenter Roeck
2013-07-17 22:09 ` [lm-sensors] [RESEND PATCH V1 0/9] thermal: introduce DT thermal zone build Guenter Roeck
2013-07-18 13:53   ` Eduardo Valentin
2013-07-18 17:18     ` Stephen Warren
2013-07-18 21:21       ` Guenter Roeck
2013-07-19 13:03         ` Eduardo Valentin [this message]
2013-07-19 18:48         ` Stephen Warren
     [not found]           ` <51E98A07.4050402-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-07-21 11:08             ` Guenter Roeck
2013-07-22 19:43               ` Stephen Warren
2013-07-22 21:46                 ` Guenter Roeck
     [not found]     ` <51E7F341.8020508-l0cyMroinI0@public.gmane.org>
2013-07-18 21:11       ` Guenter Roeck
2013-07-19 13:38         ` Eduardo Valentin
     [not found]           ` <51E9413C.2080007-l0cyMroinI0@public.gmane.org>
2013-07-19 18:45             ` Stephen Warren
2013-07-19 18:56               ` Eduardo Valentin
     [not found]                 ` <51E98BD3.8000307-l0cyMroinI0@public.gmane.org>
2013-07-21 10:14                   ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51E9392F.8060604@ti.com \
    --to=eduardo.valentin@ti.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@linaro.org \
    --cc=l.stach@pengutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=lm-sensors@lm-sensors.org \
    --cc=rob.herring@calxeda.com \
    --cc=swarren@wwwdotorg.org \
    --cc=wni@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).