From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sekhar Nori Subject: Re: [PATCH v3 5/5] ARM: davinci: serial: platform code cleanup Date: Mon, 22 Jul 2013 15:41:00 +0530 Message-ID: <51ED0534.2080408@ti.com> References: <1371633342-1210-1-git-send-email-prakash.pm@ti.com> <1371633342-1210-6-git-send-email-prakash.pm@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1371633342-1210-6-git-send-email-prakash.pm-l0cyMroinI0@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: Errors-To: davinci-linux-open-source-bounces+gld-davinci-linux-open-source=gmane.org-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org To: "Manjunathappa, Prakash" Cc: davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org, linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org, grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org, linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, hs-ynQEQJNshbs@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Wednesday 19 June 2013 02:45 PM, Manjunathappa, Prakash wrote: > 1) "struct davinci_uart_config" is introduced to specify > UART ports brought out or enabled on the board. But > none of the boards use them for that purpose, so clean > it up. > 2) Have pointer to platform device as a argument for > davinci_serial_init(), no need of serial_dev in > struct soc_info now. > 3) No need of davinci_serial_setup_clk(), not called from > multiple places, hence reduce function call overhead. 1) and 2) are related but 3) can be moved into a different patch - this patch will otherwise be doing too many things (hint for that is a vague headline and too many items to list in description) Can you respin just this patch based on v3.12/soc branch of my tree? Thanks, Sekhar