From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from avon.wwwdotorg.org ([70.85.31.133]:37790 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932388Ab3GVV6i (ORCPT ); Mon, 22 Jul 2013 17:58:38 -0400 Message-ID: <51EDAB0A.8080601@nvidia.com> Date: Mon, 22 Jul 2013 14:58:34 -0700 From: Stephen Warren MIME-Version: 1.0 Subject: Re: [PATCH V3] gpio: palmas: add dt support References: <1374469977-8805-1-git-send-email-ldewangan@nvidia.com> In-Reply-To: <1374469977-8805-1-git-send-email-ldewangan@nvidia.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org To: Laxman Dewangan Cc: linus.walleij@linaro.org, grant.likely@linaro.org, rob.herring@calxeda.com, rob@landley.net, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, kishon@ti.com, j-keerthy@ti.com, gg@slimlogic.co.uk List-ID: On 07/21/2013 10:12 PM, Laxman Dewangan wrote: > Add of_device_id table for Palma GPIO to be enable the > driver from DT file. > > The driver can be registered from DT file as: > palmas: tps65913@58 { > ::::::::::: > palmas_gpio: palmas_gpio { > compatible = "ti,palmas-gpio"; > gpio-controller; > #gpio-cells = <2>; > }; > }; > > Signed-off-by: Laxman Dewangan > diff --git a/Documentation/devicetree/bindings/gpio/gpio-palmas.txt b/Documentation/devicetree/bindings/gpio/gpio-palmas.txt > +- #gpio-cells : Should be two. > + - first cell is the gpio pin number > + - second cell is used to specify optional parameters (unused) Shouldn't the second cell contain the standard GPIO-related flags such as bit 0 == active-low? Aside from that, this binding and indeed the rest of the patch looks fine to me.