From: Stephen Warren <swarren@nvidia.com>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: linus.walleij@linaro.org, grant.likely@linaro.org,
rob.herring@calxeda.com, rob@landley.net,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
kishon@ti.com, j-keerthy@ti.com, gg@slimlogic.co.uk
Subject: Re: [PATCH V4] gpio: palmas: add dt support
Date: Tue, 23 Jul 2013 09:20:14 -0700 [thread overview]
Message-ID: <51EEAD3E.1040606@nvidia.com> (raw)
In-Reply-To: <1374564964-1281-1-git-send-email-ldewangan@nvidia.com>
On 07/23/2013 12:36 AM, Laxman Dewangan wrote:
> Add of_device_id table for Palma GPIO to be enable the
> driver from DT file.
>
> The driver can be registered from DT file as:
> palmas: tps65913@58 {
> :::::::::::
> palmas_gpio: palmas_gpio {
> compatible = "ti,palmas-gpio";
> gpio-controller;
> #gpio-cells = <2>;
> };
> };
The binding at least,
Acked-by: Stephen Warren <swarren@nvidia.com>
> diff --git a/drivers/gpio/gpio-palmas.c b/drivers/gpio/gpio-palmas.c
> #ifdef CONFIG_OF_GPIO
> - palmas_gpio->gpio_chip.of_node = palmas->dev->of_node;
> + palmas_gpio->gpio_chip.of_node = pdev->dev.of_node;
> #endif
That still scares me slightly, in case someone is already using this
driver and this changes how it works, and it breaks something, but I
don't think anyone is, so this should be OK too.
next prev parent reply other threads:[~2013-07-23 16:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-23 7:36 [PATCH V4] gpio: palmas: add dt support Laxman Dewangan
2013-07-23 16:20 ` Stephen Warren [this message]
2013-07-29 16:15 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51EEAD3E.1040606@nvidia.com \
--to=swarren@nvidia.com \
--cc=devicetree@vger.kernel.org \
--cc=gg@slimlogic.co.uk \
--cc=grant.likely@linaro.org \
--cc=j-keerthy@ti.com \
--cc=kishon@ti.com \
--cc=ldewangan@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).