From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ea0-f178.google.com ([209.85.215.178]:60574 "EHLO mail-ea0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757384Ab3GZPyI (ORCPT ); Fri, 26 Jul 2013 11:54:08 -0400 Message-ID: <51F29B9A.5080103@gmail.com> Date: Fri, 26 Jul 2013 17:54:02 +0200 From: Daniel Mack MIME-Version: 1.0 Subject: Re: [alsa-devel] [patch] ASoC: adau1701: type bug with ADAU1707_CLKDIV_UNSET References: <20130725164016.GA4027@elgon.mountain> In-Reply-To: <20130725164016.GA4027@elgon.mountain> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org To: Dan Carpenter Cc: Lars-Peter Clausen , devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Takashi Iwai , kernel-janitors@vger.kernel.org, Liam Girdwood , Rob Herring , Mark Brown , device-drivers-devel@blackfin.uclinux.org, Grant Likely List-ID: On 25.07.2013 18:40, Dan Carpenter wrote: > ADAU1707_CLKDIV_UNSET is always compared against an unsigned int and > not an unsigned long. The current tests are always false. Well, in my case, sizeof(unsigned int) equals sizeof(unsigned long), so it didn't hit me. But it should be fixed of course, thanks for catching. > Signed-off-by: Dan Carpenter Acked-by: Daniel Mack > > diff --git a/sound/soc/codecs/adau1701.c b/sound/soc/codecs/adau1701.c > index 44d8a95..2c10252 100644 > --- a/sound/soc/codecs/adau1701.c > +++ b/sound/soc/codecs/adau1701.c > @@ -91,7 +91,7 @@ > #define ADAU1701_OSCIPOW_OPD 0x04 > #define ADAU1701_DACSET_DACINIT 1 > > -#define ADAU1707_CLKDIV_UNSET (-1UL) > +#define ADAU1707_CLKDIV_UNSET (-1U) > > #define ADAU1701_FIRMWARE "adau1701.bin" > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel >