From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from avon.wwwdotorg.org ([70.85.31.133]:37432 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756835Ab3GZRLC (ORCPT ); Fri, 26 Jul 2013 13:11:02 -0400 Message-ID: <51F2ADA2.2030503@wwwdotorg.org> Date: Fri, 26 Jul 2013 11:10:58 -0600 From: Stephen Warren MIME-Version: 1.0 Subject: Re: [PATCH 1/2] mmc: add Device Tree properties for UHS modes References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org To: Guennadi Liakhovetski Cc: linux-sh@vger.kernel.org, linux-mmc@vger.kernel.org, Magnus Damm , Chris Ball , devicetree@vger.kernel.org, Simon Horman , Ian Campbell , Pawel Moll , Mark Rutland , Rob Herring List-ID: On 07/26/2013 09:51 AM, Guennadi Liakhovetski wrote: > Add DT properties for UHS SDR12, SDR25, SDR50, SDR104 and DDR50 modes and > for supported by the host in DDR mode VccQ values. Adding them to DT will > automatically enable respective MMC host capabilities. > diff --git a/Documentation/devicetree/bindings/mmc/mmc.txt b/Documentation/devicetree/bindings/mmc/mmc.txt > +- uhs-sdr12: the host supports UHS SDR12 mode > +- uhs-sdr25: the host supports UHS SDR25 mode > +- uhs-sdr50: the host supports UHS SDR50 mode > +- uhs-sdr104: the host supports UHS SDR104 mode > +- uhs-ddr50: the host supports UHS DDR50 mode > +- ddr-1v2: the host can support DDR, using 1.2V VccQ > +- ddr-1v8: the host can support DDR, using 1.8V VccQ Surely the driver for the host controller already knows this, so there's no need to represent it in DT?