From: Stephen Boyd <sboyd@codeaurora.org>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Marek Vasut <marex@denx.de>,
Fabio Estevam <fabio.estevam@freescale.com>,
Mike Turquette <mturquette@linaro.org>,
Arnd Bergmann <arnd@arndb.de>, Len Brown <len.brown@intel.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Stephen Warren <swarren@wwwdotorg.org>,
"Rafael J. Wysocki" <rjw@sisk.pl>, Pavel Machek <pavel@ucw.cz>,
Olof Johansson <olof@lixom.net>, Shawn Guo <shawn.guo@linaro.org>,
devicetree-discuss@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
Roger Quadros <rogerq@ti.com>
Subject: Re: [PATCH v11] reset: Add driver for gpio-controlled reset pins
Date: Fri, 26 Jul 2013 13:15:06 -0700 [thread overview]
Message-ID: <51F2D8CA.4010601@codeaurora.org> (raw)
In-Reply-To: <1374834384-8071-1-git-send-email-p.zabel@pengutronix.de>
On 07/26/13 03:26, Philipp Zabel wrote:
> +#include <linux/platform_device.h>
> +#include <linux/reset-controller.h>
> +
> +struct gpio_reset_data {
> + struct reset_controller_dev rcdev;
> + unsigned int gpio;
> + bool active_low;
> + s32 delay_us;
Maybe I missed it, why is this signed? Do we plan to have negative time
delays?
>
> +
> +static struct reset_control_ops gpio_reset_ops = {
const?
> + .reset = gpio_reset,
> + .assert = gpio_reset_assert,
> + .deassert = gpio_reset_deassert,
> +};
>
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2013-07-26 20:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-26 10:26 [PATCH v11] reset: Add driver for gpio-controlled reset pins Philipp Zabel
2013-07-26 20:15 ` Stephen Boyd [this message]
2013-07-26 21:05 ` Ben Dooks
2013-07-26 21:30 ` Sylwester Nawrocki
2013-07-27 17:38 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F2D8CA.4010601@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=arnd@arndb.de \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=fabio.estevam@freescale.com \
--cc=len.brown@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=marex@denx.de \
--cc=mturquette@linaro.org \
--cc=olof@lixom.net \
--cc=p.zabel@pengutronix.de \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
--cc=rogerq@ti.com \
--cc=s.hauer@pengutronix.de \
--cc=shawn.guo@linaro.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).