From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Dooks <ben.dooks@codethink.co.uk>
Subject: Re: [PATCH v11] reset: Add driver for gpio-controlled reset pins
Date: Sat, 27 Jul 2013 18:38:16 +0100
Message-ID: <51F40588.9020907@codethink.co.uk>
References: <1374834384-8071-1-git-send-email-p.zabel@pengutronix.de>
 <51F2E4A7.1040200@codethink.co.uk> <51F2EA59.8010908@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org>
In-Reply-To: <51F2EA59.8010908@gmail.com>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>,
 <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/>
List-Post: <mailto:linux-arm-kernel@lists.infradead.org>
List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>,
 <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>
Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org>
Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org
To: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
Cc: Marek Vasut <marex@denx.de>, Fabio Estevam <fabio.estevam@freescale.com>, Mike Turquette <mturquette@linaro.org>, Pavel Machek <pavel@ucw.cz>, Arnd Bergmann <arnd@arndb.de>, Len Brown <len.brown@intel.com>, Sascha Hauer <s.hauer@pengutronix.de>, Stephen Warren <swarren@wwwdotorg.org>, "Rafael J. Wysocki" <rjw@sisk.pl>, Philipp Zabel <p.zabel@pengutronix.de>, Olof Johansson <olof@lixom.net>, Shawn Guo <shawn.guo@linaro.org>, devicetree-discuss@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, Roger Quadros <rogerq@ti.com>
List-Id: devicetree@vger.kernel.org

On 26/07/13 22:30, Sylwester Nawrocki wrote:
> On 07/26/2013 11:05 PM, Ben Dooks wrote:
>> On 26/07/13 11:26, Philipp Zabel wrote:
>>> This driver implements a reset controller device that toggle a gpio
>>> connected to a reset pin of a peripheral IC. The delay between assertion
>>> and de-assertion of the reset signal can be configured via device tree.
>>>
>>> Signed-off-by: Philipp Zabel<p.zabel@pengutronix.de>
>>> Reviewed-by: Stephen Warren<swarren@nvidia.com>
>>
>> [snip]
>>
>>> +static struct of_device_id gpio_reset_dt_ids[] = {
>>> + { .compatible = "gpio-reset" },
>>> + { }
>>> +};
>>
>> I think you need the following:
>> MODULE_DEVICE_TABLE(of, gpio_reset_dt_ids);
>
> It's already there, at bottom of the file. But if I'm not mistaken
> the common practice is to keep it together with the actual array
> definition. At least that's the case with, e.g. EXPORT_SYMBOL*.
>
>>> +static struct platform_driver gpio_reset_driver = {
>>> + .probe = gpio_reset_probe,
>>> + .remove = gpio_reset_remove,
>>> + .driver = {
>>> + .name = "gpio-reset",
>>> + .owner = THIS_MODULE,
>>> + .of_match_table = of_match_ptr(gpio_reset_dt_ids),
>>> + },
>>> +};
>>> +
>>> +module_platform_driver(gpio_reset_driver);
>>> +
>>> +MODULE_AUTHOR("Philipp Zabel<p.zabel@pengutronix.de>");
>>> +MODULE_DESCRIPTION("gpio reset controller");
>
> nit: shouldn't gpio be capitalized ?
>
>>> +MODULE_LICENSE("GPL");
>>> +MODULE_ALIAS("platform:gpio-reset");
>>> +MODULE_DEVICE_TABLE(of, gpio_reset_dt_ids);
>
> --
> Regards,
> Sylwester

ta, that's why I missed it. Nice if it stays with the table it
references.

-- 
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius