devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Benoit Cousson <benoit.cousson@gmail.com>
To: Nishanth Menon <nm@ti.com>
Cc: "Benoît Cousson" <benoit.cousson@linaro.org>,
	"Tony Lindgren" <tony@atomide.com>,
	linux-omap@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, "J Keerthy" <j-keerthy@ti.com>
Subject: Re: [PATCH 0/9] ARM: dts: omap5-uevm: fixup wrong regulator configuration
Date: Mon, 29 Jul 2013 15:39:59 +0200	[thread overview]
Message-ID: <51F670AF.9080808@gmail.com> (raw)
In-Reply-To: <51F66B65.4030702@ti.com>

Hi Nishanth,

On 29/07/2013 15:17, Nishanth Menon wrote:
> On 07/29/2013 04:57 AM, Keerthy wrote:
>> Hi Nishanth,
>>
>> On Wednesday 17 July 2013 10:15 PM, Nishanth Menon wrote:
>>> Due to wrong older revision of documentation used as reference, we
>>> seem to have a bunch of LDOs wrongly configured on OMAP5 uEVM. This
>>> series is based power tree on production board 750-2628-XXX platform.
>>> Unfortunately, the wrong voltages may be detrimental to OMAP5 as they
>>> supply hardware blocks at voltages that are out of specification.
>>
>> This series looks good to me.
>>
>> Acked-by:  J Keerthy <j-keerthy@ti.com>
>
> Tony, Benoit - this series could prevent OMAP5 from being damaged on
> uEVMs with current 3.11 rc - could you suggest what we need to do to
> get it in?

I'm still on vacation with no way to pull any patch... but I can still
comment on the series quickly.

It seems to me that this series contains some real fixes that might
damage the board due to hihest voltage than expected and some which are
just improvement like for the SMPS9 or LDO[28]. In theory they should no
go necesseraly to -rc, but, I guess that's fine for that one.

All the "fixes" are sharing more than 50% of the changelog content with
only 2 changes in the code, so you'd better squash them into one patch
to avoid repeating the same thing again and again.

Beside that, I will ack the updated one to allow Tony to push them ASAP.

Regards,
Benoit

      reply	other threads:[~2013-07-29 13:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-17 16:45 [PATCH 0/9] ARM: dts: omap5-uevm: fixup wrong regulator configuration Nishanth Menon
2013-07-17 16:45 ` [PATCH 1/9] ARM: dts: omap5-uevm: document regulator signals used on the actual board Nishanth Menon
2013-07-17 16:45 ` [PATCH 3/9] ARM: dts: omap5-uevm: update and disable unused regulators LDO[28] Nishanth Menon
2013-07-17 16:45 ` [PATCH 4/9] ARM: dts: omap5-uevm: update LDO1 voltage to 1.5V and settings Nishanth Menon
     [not found] ` <1374079538-19548-1-git-send-email-nm-l0cyMroinI0@public.gmane.org>
2013-07-17 16:45   ` [PATCH 2/9] ARM: dts: omap5-uevm: update SMPS9 settings Nishanth Menon
2013-07-17 16:45   ` [PATCH 5/9] ARM: dts: omap5-uevm: update LDO3 voltage to 1.5V and settings Nishanth Menon
2013-07-17 16:45   ` [PATCH 6/9] ARM: dts: omap5-uevm: update LDO4 " Nishanth Menon
2013-07-17 16:45   ` [PATCH 8/9] ARM: dts: omap5-uevm: update LDO7 voltage to 2V " Nishanth Menon
2013-07-17 16:45 ` [PATCH 7/9] ARM: dts: omap5-uevm: update LDO6 voltage to 1.2V Nishanth Menon
2013-07-17 16:45 ` [PATCH 9/9] ARM: dts: omap5-uevm: update SDCARD LDO9 and resource REGEN3 Nishanth Menon
2013-07-29  9:57 ` [PATCH 0/9] ARM: dts: omap5-uevm: fixup wrong regulator configuration Keerthy
2013-07-29 13:17   ` Nishanth Menon
2013-07-29 13:39     ` Benoit Cousson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51F670AF.9080808@gmail.com \
    --to=benoit.cousson@gmail.com \
    --cc=benoit.cousson@linaro.org \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=j-keerthy@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).