From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from avon.wwwdotorg.org ([70.85.31.133]:42476 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752398Ab3GaRUK (ORCPT ); Wed, 31 Jul 2013 13:20:10 -0400 Message-ID: <51F94744.40301@wwwdotorg.org> Date: Wed, 31 Jul 2013 11:20:04 -0600 From: Stephen Warren MIME-Version: 1.0 Subject: Re: [PATCH v2 1/1] mfd: palmas: Add power off control References: <1375255037-10024-1-git-send-email-bilhuang@nvidia.com> <51F8FBC4.1040009@ti.com> In-Reply-To: <51F8FBC4.1040009@ti.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org To: Nishanth Menon Cc: Bill Huang , sameo@linux.intel.com, rob.herring@calxeda.com, pawel.moll@arm.com, mark.rutland@arm.com, ian.campbell@citrix.com, rob@landley.net, lee.jones@linaro.org, broonie@linaro.org, j-keerthy@ti.com, grant.likely@linaro.org, ian@slimlogic.co.uk, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Mallikarjun Kasoju List-ID: On 07/31/2013 05:57 AM, Nishanth Menon wrote: > On 07/31/2013 02:17 AM, Bill Huang wrote: >> Hook up "pm_power_off" to palmas power off routine if there is DT >> property "ti,system-power-controller" defined, so platform which is >> powered by this regulator can be powered off properly. >> >> Based on work by: >> Mallikarjun Kasoju >> >> Signed-off-by: Bill Huang >> cc: Mallikarjun Kasoju >> --- >> .../devicetree/bindings/regulator/palmas-pmic.txt | 5 +++ >> drivers/mfd/palmas.c | 33 >> ++++++++++++++++++-- > > Since the specific question on v1 was not answered, I will ask again, > any reason why it wont fit in drivers/power/reset/ is'nt it the right > place to add this? I think it makes sense to put simple standalone reset drivers into drivers/power/reset. However, where reset is just one tiny function of a larger device that already has a driver, it's fine for one driver to implement multiple features or essentially expose multiple subsystems. (besides this is system power off not system reset; which is drivers/power/reset?)