devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Laxman Dewangan <ldewangan@nvidia.com>
To: "balbi@ti.com" <balbi@ti.com>
Cc: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"grant.likely@linaro.org" <grant.likely@linaro.org>,
	"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
	"rob@landley.net" <rob@landley.net>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"rtc-linux@googlegroups.com" <rtc-linux@googlegroups.com>,
	"gg@slimlogic.co.uk" <gg@slimlogic.co.uk>,
	"kishon@ti.com" <kishon@ti.com>,
	Stephen Warren <swarren@nvidia.com>,
	"pawel.moll@arm.com" <pawel.moll@arm.com>,
	"Mark.Rutland@arm.com" <Mark.Rutland@arm.com>,
	"ian.campbell@citrix.com" <ian.campbell@citrix.com>,
	"broonie@kernel.org" <broonie@kernel.org>
Subject: Re: [PATCH V2] drivers/rtc/rtc-palmas.c: support for backup battery charging
Date: Thu, 1 Aug 2013 21:03:13 +0530	[thread overview]
Message-ID: <51FA7FB9.8000209@nvidia.com> (raw)
In-Reply-To: <20130801150941.GA11286@radagast>

On Thursday 01 August 2013 08:39 PM, Felipe Balbi wrote:
> * PGP Signed by an unknown key
>
> Hi,
>
> On Thu, Aug 01, 2013 at 08:01:11PM +0530, Laxman Dewangan wrote:
> I wonder if this should be exposed via power_supply class, although it's
> not really a power supply. So perhaps not needed :-s

Yes, there is another charger module on the device which actually need 
the driver through power supply. Charger submodule used for charging the 
main battery through USB VBUS.




>
> looks good though (can't test as I don't have any boards available right
> now):
>
> Reviewed-by: Felipe Balbi <balbi@ti.com>

Thanks for review.
>


  reply	other threads:[~2013-08-01 15:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-01 14:31 [PATCH V2] drivers/rtc/rtc-palmas.c: support for backup battery charging Laxman Dewangan
2013-08-01 15:09 ` Felipe Balbi
2013-08-01 15:33   ` Laxman Dewangan [this message]
2013-08-01 16:44 ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51FA7FB9.8000209@nvidia.com \
    --to=ldewangan@nvidia.com \
    --cc=Mark.Rutland@arm.com \
    --cc=akpm@linux-foundation.org \
    --cc=balbi@ti.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gg@slimlogic.co.uk \
    --cc=grant.likely@linaro.org \
    --cc=ian.campbell@citrix.com \
    --cc=kishon@ti.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pawel.moll@arm.com \
    --cc=rob.herring@calxeda.com \
    --cc=rob@landley.net \
    --cc=rtc-linux@googlegroups.com \
    --cc=swarren@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).