From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp131.dfw.emailsrvr.com ([67.192.241.131]:60694 "EHLO smtp131.dfw.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753045Ab3HBPYv (ORCPT ); Fri, 2 Aug 2013 11:24:51 -0400 Message-ID: <51FBCF05.9090509@calxeda.com> Date: Fri, 02 Aug 2013 10:23:49 -0500 From: Mark Langsdorf MIME-Version: 1.0 Subject: Re: [PATCH 1/5] sata, highbank: fix ordering of SGPIO signals References: <1374851518-4802-1-git-send-email-mark.langsdorf@calxeda.com> <20130729165530.GG22605@mtj.dyndns.org> In-Reply-To: <20130729165530.GG22605@mtj.dyndns.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org To: Tejun Heo Cc: "linux-kernel@vger.kernel.org" , "linux-ide@vger.kernel.org" , "devicetree@vger.kernel.org" , "pawel.moll@arm.com" , "mark.rutland@arm.com" , "swarren@wwwdotorg.org" , "ian.campbell@citrix.com" , Rob Herring List-ID: On 07/29/2013 11:55 AM, Tejun Heo wrote: > On Fri, Jul 26, 2013 at 10:11:54AM -0500, Mark Langsdorf wrote: >> The ACTIVITY and ERROR signals were reversed in the original commit. >> Fix that. > > And what's the implication of this change? Does this change the > behavior of the driver? If so, how? If not, why not? *Please* be > more descriptive in patch descriptions and explain *why* the changes > are being made. I didn't think I needed more of an explanation than "this is completely wrong per the spec" but I'll revise and resubmit. --Mark Langsdorf Calxeda, Inc.