From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f179.google.com ([209.85.212.179]:45928 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752586Ab3HCWFN (ORCPT ); Sat, 3 Aug 2013 18:05:13 -0400 Message-ID: <51FD7E95.4040301@gmail.com> Date: Sun, 04 Aug 2013 00:05:09 +0200 From: Sylwester Nawrocki MIME-Version: 1.0 Subject: Re: [RFC v3 11/13] [media] exynos5-is: Add Kconfig and Makefile References: <1375455762-22071-1-git-send-email-arun.kk@samsung.com> <1375455762-22071-12-git-send-email-arun.kk@samsung.com> In-Reply-To: <1375455762-22071-12-git-send-email-arun.kk@samsung.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org To: Arun Kumar K Cc: linux-media@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, s.nawrocki@samsung.com, hverkuil@xs4all.nl, a.hajda@samsung.com, sachin.kamat@linaro.org, shaik.ameer@samsung.com, kilyeon.im@samsung.com, arunkk.samsung@gmail.com List-ID: On 08/02/2013 05:02 PM, Arun Kumar K wrote: > Adds Kconfig and Makefile for exynos5-is driver files. > > Signed-off-by: Shaik Ameer Basha > Signed-off-by: Kilyeon Im > Signed-off-by: Arun Kumar K > --- > drivers/media/platform/Kconfig | 1 + > drivers/media/platform/Makefile | 1 + > drivers/media/platform/exynos5-is/Kconfig | 19 +++++++++++++++++++ > drivers/media/platform/exynos5-is/Makefile | 7 +++++++ > 4 files changed, 28 insertions(+) > create mode 100644 drivers/media/platform/exynos5-is/Kconfig > create mode 100644 drivers/media/platform/exynos5-is/Makefile > > diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig > index 08de865..4b0475e 100644 > --- a/drivers/media/platform/Kconfig > +++ b/drivers/media/platform/Kconfig > @@ -123,6 +123,7 @@ config VIDEO_S3C_CAMIF > > source "drivers/media/platform/soc_camera/Kconfig" > source "drivers/media/platform/exynos4-is/Kconfig" > +source "drivers/media/platform/exynos5-is/Kconfig" > source "drivers/media/platform/s5p-tv/Kconfig" > > endif # V4L_PLATFORM_DRIVERS > diff --git a/drivers/media/platform/Makefile b/drivers/media/platform/Makefile > index eee28dd..b1225e5 100644 > --- a/drivers/media/platform/Makefile > +++ b/drivers/media/platform/Makefile > @@ -37,6 +37,7 @@ obj-$(CONFIG_VIDEO_SAMSUNG_S5P_TV) += s5p-tv/ > > obj-$(CONFIG_VIDEO_SAMSUNG_S5P_G2D) += s5p-g2d/ > obj-$(CONFIG_VIDEO_SAMSUNG_EXYNOS_GSC) += exynos-gsc/ > +obj-$(CONFIG_VIDEO_SAMSUNG_EXYNOS5_MDEV) += exynos5-is/ > > obj-$(CONFIG_BLACKFIN) += blackfin/ > > diff --git a/drivers/media/platform/exynos5-is/Kconfig b/drivers/media/platform/exynos5-is/Kconfig > new file mode 100644 > index 0000000..99d5edf > --- /dev/null > +++ b/drivers/media/platform/exynos5-is/Kconfig > @@ -0,0 +1,19 @@ > +config VIDEO_SAMSUNG_EXYNOS5_MDEV Wouldn't VIDEO_SAMSUNG_EXYNOS5_CAMERA be a better symbol name ? > + bool "Samsung Exynos5 Media Device driver" > + depends on VIDEO_V4L2&& VIDEO_V4L2_SUBDEV_API&& PM_RUNTIME&& VIDEO_SAMSUNG_EXYNOS4_IS nit: It might make sense to put "depends on VIDEO_SAMSUNG_EXYNOS4_IS" in a separate line so it stands out a bit. > + help > + This is a v4l2 based media controller driver for > + Exynos5 SoC. > + > +if VIDEO_SAMSUNG_EXYNOS5_MDEV > + > +config VIDEO_SAMSUNG_EXYNOS5_FIMC_IS > + tristate "Samsung Exynos5 SoC FIMC-IS driver" > + depends on I2C&& OF > + depends on VIDEO_EXYNOS4_FIMC_IS > + select VIDEOBUF2_DMA_CONTIG > + help > + This is a V4L2 driver for Samsung Exynos5 SoC series Imaging > + Subsystem known as FIMC-IS. > + > +endif #VIDEO_SAMSUNG_EXYNOS5_MDEV > diff --git a/drivers/media/platform/exynos5-is/Makefile b/drivers/media/platform/exynos5-is/Makefile > new file mode 100644 > index 0000000..c4e37e0 > --- /dev/null > +++ b/drivers/media/platform/exynos5-is/Makefile > @@ -0,0 +1,7 @@ > +ccflags-y += -Idrivers/media/platform/exynos4-is > +exynos5-fimc-is-objs := fimc-is-core.o fimc-is-isp.o fimc-is-scaler.o > +exynos5-fimc-is-objs += fimc-is-pipeline.o fimc-is-interface.o fimc-is-sensor.o > +exynos-mdevice-objs := exynos5-mdev.o > + > +obj-$(CONFIG_VIDEO_SAMSUNG_EXYNOS5_FIMC_IS) += exynos5-fimc-is.o > +obj-$(CONFIG_VIDEO_SAMSUNG_EXYNOS5_MDEV) += exynos-mdevice.o -- Thanks, Sylwester