From: George Cherian <george.cherian@ti.com>
To: Roger Quadros <rogerq@ti.com>
Cc: tony@atomide.com, rnayak@ti.com, benoit.cousson@linaro.org,
balbi@ti.com, kishon@ti.com, dmurphy@ti.com, t-kristo@ti.com,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] dts: dra7-evm: add USB support
Date: Mon, 5 Aug 2013 14:33:01 +0530 [thread overview]
Message-ID: <51FF6A45.3060702@ti.com> (raw)
In-Reply-To: <51FF5A69.7040604@ti.com>
On 8/5/2013 1:25 PM, Roger Quadros wrote:
> On 08/02/2013 06:04 PM, George Cherian wrote:
>> On 8/1/2013 8:28 PM, Roger Quadros wrote:
>>> Add USB drv_vbus pinctrl information and USB mode
>>> for the USB controller.
>>>
>>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>>> ---
>>> arch/arm/boot/dts/dra7-evm.dts | 22 ++++++++++++++++++++++
>>> 1 files changed, 22 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts
>>> index cb0703c..acd3c09 100644
>>> --- a/arch/arm/boot/dts/dra7-evm.dts
>>> +++ b/arch/arm/boot/dts/dra7-evm.dts
>>> @@ -18,3 +18,25 @@
>>> reg = <0x80000000 0x60000000>; /* 1536 MB */
>>> };
>>> };
>>> +
>>> +&dra7_pmx_core {
>>> + pinctrl-names = "default";
>>> + pinctrl-0 = <
>>> + &usb_pins
>>> + >;
>>> +
>>> + usb_pins: pinmux_usb_pins {
>>> + pinctrl-single,pins = <
>>> + 0x280 0xc0000 /* usb1_drvvbus, SLOW_SLEW | PULLUPEN | MODE0 */
>>> + 0x284 0xc0000 /* usb2_drvvbus, SLOW_SLEW | PULLUPEN | MODE0 */
>>> + >;
>>> + };
>>> +};
>>> +
>>> +&dwc3_1 {
>>> + dr_mode = "otg";
>> otg???
> What's wrong there?
> please see
> Documentation/devicetree/bindings/usb/generic.txt
>
> we want it to operate in dual role mode and hence "otg"
Am sorry for not being clear with my earlier comment.
I meant whether we have otg/ DRD working. Till then shouldnt we put
either peripheral/host?
> cheers,
> -roger
--
-George
next prev parent reply other threads:[~2013-08-05 9:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-01 14:58 [PATCH 0/4] ARM: DRA7-evm: USB host adaptation Roger Quadros
2013-08-01 14:58 ` [PATCH 1/4] CLK: ti: dra7: Initialize USB_DPLL Roger Quadros
2013-08-01 15:06 ` Nishanth Menon
2013-08-02 7:30 ` Roger Quadros
2013-08-02 10:57 ` Tero Kristo
2013-08-02 12:52 ` Nishanth Menon
2013-08-01 14:58 ` [PATCH 2/4] ARM: dts: dra7: Add USB related nodes Roger Quadros
2013-08-02 15:02 ` George Cherian
2013-08-05 7:52 ` Roger Quadros
2013-08-01 14:58 ` [PATCH 3/4] dts: dra7-evm: add USB support Roger Quadros
2013-08-02 15:04 ` George Cherian
2013-08-05 7:55 ` Roger Quadros
2013-08-05 9:03 ` George Cherian [this message]
2013-08-05 10:23 ` Roger Quadros
2013-08-01 14:58 ` [PATCH 4/4] ARM: DRA7: hwmod: Add SYSCONFIG for usb_otg_ss Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51FF6A45.3060702@ti.com \
--to=george.cherian@ti.com \
--cc=balbi@ti.com \
--cc=benoit.cousson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=rnayak@ti.com \
--cc=rogerq@ti.com \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).