From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A8E0C4332F for ; Fri, 13 May 2022 09:33:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378934AbiEMJd1 (ORCPT ); Fri, 13 May 2022 05:33:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355885AbiEMJdZ (ORCPT ); Fri, 13 May 2022 05:33:25 -0400 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B8012016DC for ; Fri, 13 May 2022 02:33:24 -0700 (PDT) Received: by mail-wr1-x434.google.com with SMTP id e29so993753wrc.11 for ; Fri, 13 May 2022 02:33:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=iI3J6M1c5C8y5M42ZpMfl0r//lsinVxxLKzK6eOUa+g=; b=IGYqWfrSe/zPdzA+FAV8IXXHkrsYYwh17HRvpEGw9XCStqqe3r97vxTIFNNCz75GST zeTJHwhcBSeB4Spp+OCiaH6Ee8HzIj1zSxthAHwwch3k96WO+pz5fYUFAcrdRb5I0G+H r+sZaqga//r0OrCu+VvFbyB0AYE3NcdP3f2rsFj5IHbzkJA++ETAkaj4yqglyw0GmgUb M2HXBYz/Mq76XSUfbplsMpdvwv5/wdfhDBe5nC1MaJ/ZmLg7C02JfrCbQjY2tKyHERrS EhVNEdrbL4DxKGN+8/oIA5+eLnNMaSidXFAE2n2Y7Swo4y1LBdt413SomXermFA7BHnR oP3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=iI3J6M1c5C8y5M42ZpMfl0r//lsinVxxLKzK6eOUa+g=; b=7pp0/WcjrlgqUFN/GOWe4fpxJAVHkfO4347pjKD/sM39ush3fz6Ik/1Jsn1IOda+gN 4m5fMS44MCGkh7OhkSjYBtLNu0Tp08tlFooFSSDhsiRnVaxisQ83x3pAOK+i5PLlSjAl zH/KxvDnrPOgauHUPfseUngyaHCh7KQF3vrLOhMOyBTjA27MXaN1sKF1QAiQrf3GN5X8 umDwpIw13oM90DJwLusPEDx58SD1+sc96kB9rKHAq20vW4HOgiEAxyWCC0rGgZ3vKAQI LTROuLbfPMDqkHIigeEWlKW3WZO0HUlq4Sb+3MAwDV6jssvCRMoPhXnoITbnzi3o0yFB l0xA== X-Gm-Message-State: AOAM532pYtN9L9aPEgPnQYElohBKYfDf0B7rxVR+StJAAG74RWHbTmcI jrnQt5FIOJuzJGRpm6ftsU8Tug== X-Google-Smtp-Source: ABdhPJzvZbiscTccrd3tJU+uxCEixUkPIVIKLgalKrvbjaWWl4ngAWd5lJ6uj4iWaC8Tjm50jASYAg== X-Received: by 2002:a5d:640f:0:b0:20c:9be6:30c1 with SMTP id z15-20020a5d640f000000b0020c9be630c1mr3066931wru.273.1652434402658; Fri, 13 May 2022 02:33:22 -0700 (PDT) Received: from [192.168.0.171] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id c13-20020adfa70d000000b0020c5253d8f7sm1729851wrd.67.2022.05.13.02.33.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 May 2022 02:33:22 -0700 (PDT) Message-ID: <51a9cc50-72ab-2417-1a22-0d85a944d00b@linaro.org> Date: Fri, 13 May 2022 11:33:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 5/7] arm64: dts: qcom: Add PM6125 PMIC Content-Language: en-US To: Marijn Suijten , phone-devel@vger.kernel.org, Bjorn Andersson , ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , Andy Gross , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220511220613.1015472-1-marijn.suijten@somainline.org> <20220511220613.1015472-6-marijn.suijten@somainline.org> <7c7f7036-e3ad-c9db-2c31-749e2d01e83d@linaro.org> <20220513092551.hvz5jvej57cgvavj@SoMainline.org> From: Krzysztof Kozlowski In-Reply-To: <20220513092551.hvz5jvej57cgvavj@SoMainline.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 13/05/2022 11:25, Marijn Suijten wrote: >>> + #address-cells = <1>; >>> + #size-cells = <0>; >> >> No children, so this should not be needed, I think. > > The size-cells or the entire node? There's a PWM/LPG block here > according to downstream DT, but my device doesn't use it so I can't test > that it is valid. I can add it anyway, presuming reviewers here have > the ability to validate it for me with a reference manual. I mean only the address/size cells. They are needed for the children, unless some binding expects it? Best regards, Krzysztof