From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D1ECC678DC for ; Fri, 18 Aug 2023 10:16:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238126AbjHRKP7 (ORCPT ); Fri, 18 Aug 2023 06:15:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1359855AbjHRKPr (ORCPT ); Fri, 18 Aug 2023 06:15:47 -0400 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 949D54214; Fri, 18 Aug 2023 03:15:28 -0700 (PDT) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id 0385C24E2C5; Fri, 18 Aug 2023 18:15:21 +0800 (CST) Received: from EXMBX171.cuchost.com (172.16.6.91) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Fri, 18 Aug 2023 18:15:20 +0800 Received: from [192.168.125.127] (183.27.97.249) by EXMBX171.cuchost.com (172.16.6.91) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Fri, 18 Aug 2023 18:15:19 +0800 Message-ID: <51bd9a0b-d8b1-35b4-4f8a-2ef0e9564439@starfivetech.com> Date: Fri, 18 Aug 2023 18:15:19 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v3 06/11] PCI: plda: Add event interrupt codes and IRQ domain ops Content-Language: en-US To: Conor Dooley CC: Conor Dooley , Daire McNamara , Rob Herring , "Krzysztof Kozlowski" , Bjorn Helgaas , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= , Emil Renner Berthing , , , , , =?UTF-8?Q?Pali_Roh=c3=a1r?= , Paul Walmsley , Palmer Dabbelt , Albert Ou , Philipp Zabel , Mason Huo , Leyfoon Tan , Kevin Xie References: <20230814082016.104181-1-minda.chen@starfivetech.com> <20230814082016.104181-7-minda.chen@starfivetech.com> <20230814-episode-untidy-c66107a33ea0@wendy> <20230815-five-comment-cff5fb01909f@spud> From: Minda Chen In-Reply-To: <20230815-five-comment-cff5fb01909f@spud> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [183.27.97.249] X-ClientProxiedBy: EXCAS061.cuchost.com (172.16.6.21) To EXMBX171.cuchost.com (172.16.6.91) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2023/8/15 21:11, Conor Dooley wrote: > On Tue, Aug 15, 2023 at 06:12:07PM +0800, Minda Chen wrote: >> >> >> On 2023/8/14 21:52, Conor Dooley wrote: >> > On Mon, Aug 14, 2023 at 04:20:11PM +0800, Minda Chen wrote: >> >> For PolarFire implements non-PLDA local interrupt events, most of >> >> event interrupt process codes can not be re-used. PLDA implements >> >> new codes and IRQ domain ops like PolarFire. >> >> >> >> plda_handle_event adds a new IRQ num to event num mapping codes for >> >> PLDA local event except DMA engine interrupt events. The DMA engine >> >> interrupt events are implemented by vendors. >> >> >> >> Signed-off-by: Minda Chen >> >> --- >> >> .../pci/controller/plda/pcie-microchip-host.c | 29 +++--- >> >> drivers/pci/controller/plda/pcie-plda-host.c | 99 +++++++++++++++++++ >> >> drivers/pci/controller/plda/pcie-plda.h | 19 ++++ >> >> 3 files changed, 133 insertions(+), 14 deletions(-) >> >> >> >> diff --git a/drivers/pci/controller/plda/pcie-microchip-host.c b/drivers/pci/controller/plda/pcie-microchip-host.c >> >> index c28840315019..b42f1aac3ec3 100644 >> >> --- a/drivers/pci/controller/plda/pcie-microchip-host.c >> >> +++ b/drivers/pci/controller/plda/pcie-microchip-host.c >> >> @@ -96,20 +96,21 @@ >> >> #define EVENT_LOCAL_DMA_END_ENGINE_1 12 >> >> #define EVENT_LOCAL_DMA_ERROR_ENGINE_0 13 >> >> #define EVENT_LOCAL_DMA_ERROR_ENGINE_1 14 >> >> -#define EVENT_LOCAL_A_ATR_EVT_POST_ERR 15 >> >> -#define EVENT_LOCAL_A_ATR_EVT_FETCH_ERR 16 >> >> -#define EVENT_LOCAL_A_ATR_EVT_DISCARD_ERR 17 >> >> -#define EVENT_LOCAL_A_ATR_EVT_DOORBELL 18 >> >> -#define EVENT_LOCAL_P_ATR_EVT_POST_ERR 19 >> >> -#define EVENT_LOCAL_P_ATR_EVT_FETCH_ERR 20 >> >> -#define EVENT_LOCAL_P_ATR_EVT_DISCARD_ERR 21 >> >> -#define EVENT_LOCAL_P_ATR_EVT_DOORBELL 22 >> >> -#define EVENT_LOCAL_PM_MSI_INT_INTX 23 >> >> -#define EVENT_LOCAL_PM_MSI_INT_MSI 24 >> >> -#define EVENT_LOCAL_PM_MSI_INT_AER_EVT 25 >> >> -#define EVENT_LOCAL_PM_MSI_INT_EVENTS 26 >> >> -#define EVENT_LOCAL_PM_MSI_INT_SYS_ERR 27 >> >> -#define NUM_EVENTS 28 >> >> +#define NUM_MC_EVENTS 15 >> >> +#define EVENT_LOCAL_A_ATR_EVT_POST_ERR (NUM_MC_EVENTS + EVENT_A_ATR_EVT_POST_ERR) >> >> +#define EVENT_LOCAL_A_ATR_EVT_FETCH_ERR (NUM_MC_EVENTS + EVENT_A_ATR_EVT_FETCH_ERR) >> >> +#define EVENT_LOCAL_A_ATR_EVT_DISCARD_ERR (NUM_MC_EVENTS + EVENT_A_ATR_EVT_DISCARD_ERR) >> >> +#define EVENT_LOCAL_A_ATR_EVT_DOORBELL (NUM_MC_EVENTS + EVENT_A_ATR_EVT_DOORBELL) >> >> +#define EVENT_LOCAL_P_ATR_EVT_POST_ERR (NUM_MC_EVENTS + EVENT_P_ATR_EVT_POST_ERR) >> >> +#define EVENT_LOCAL_P_ATR_EVT_FETCH_ERR (NUM_MC_EVENTS + EVENT_P_ATR_EVT_FETCH_ERR) >> >> +#define EVENT_LOCAL_P_ATR_EVT_DISCARD_ERR (NUM_MC_EVENTS + EVENT_P_ATR_EVT_DISCARD_ERR) >> >> +#define EVENT_LOCAL_P_ATR_EVT_DOORBELL (NUM_MC_EVENTS + EVENT_P_ATR_EVT_DOORBELL) >> >> +#define EVENT_LOCAL_PM_MSI_INT_INTX (NUM_MC_EVENTS + EVENT_PM_MSI_INT_INTX) >> >> +#define EVENT_LOCAL_PM_MSI_INT_MSI (NUM_MC_EVENTS + EVENT_PM_MSI_INT_MSI) >> >> +#define EVENT_LOCAL_PM_MSI_INT_AER_EVT (NUM_MC_EVENTS + EVENT_PM_MSI_INT_AER_EVT) >> >> +#define EVENT_LOCAL_PM_MSI_INT_EVENTS (NUM_MC_EVENTS + EVENT_PM_MSI_INT_EVENTS) >> >> +#define EVENT_LOCAL_PM_MSI_INT_SYS_ERR (NUM_MC_EVENTS + EVENT_PM_MSI_INT_SYS_ERR) >> >> +#define NUM_EVENTS (NUM_MC_EVENTS + NUM_PLDA_EVENTS) >> > >> > Is this change not in the wrong patch & should be changed alongside the >> > movement of defines? >> EVENT_xxx is new added one for PLDA codes and The event num start from 0. This add association to PLDA events. >> Maybe this can be moved to patch8 or a new patch. > > It feels like it should be in patch 3 to me. OK, thanks. But this need define PLDA events macros in patch3.