From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 016F7C38145 for ; Thu, 8 Sep 2022 10:23:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230181AbiIHKXN (ORCPT ); Thu, 8 Sep 2022 06:23:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229976AbiIHKXL (ORCPT ); Thu, 8 Sep 2022 06:23:11 -0400 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91DD5D2740 for ; Thu, 8 Sep 2022 03:23:10 -0700 (PDT) Received: by mail-lf1-x136.google.com with SMTP id x14so11575817lfu.10 for ; Thu, 08 Sep 2022 03:23:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=71ULh6vj0eJOKdAumyIOV8TqB+wxiHSVYFR9puUSOIA=; b=P//ALHVYYciXScMLp7+9vpKQ4XAN0wEETZyPFlT6E3f96d68C+LdDDb9Lk5d0pvkKZ LJCbdaMyYDBXzyJK3qmY4lHSTj2cObcRrk8VyU+citDgi4Ni1uTUk+6t/GQSqAxK+3ij bRP6dlUkdoYF+bQCwKSpZBlDm8TQDKvj4KBZLJtZiEt4r3IMtVDJQR83Bh/m/sjMP+w/ otK2YYqfBE1kKgSfHEFjTy6QpXJSUnzD5j512Y6msbAqHp8vLa43fXwh+gl4v+95vBiC 4TXEqU9O0NdbH0n6qbystDGRKh8oxTo5IZBIAFIEZfFFEL0gmaZkCrRKKrmBuftbrAL9 Bj3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=71ULh6vj0eJOKdAumyIOV8TqB+wxiHSVYFR9puUSOIA=; b=Gipxx/Htge+g5pRE+FaMGG9giCBnDhroK9urXf9ykIGfIj+SWIJzM+T73fg1Vdmclc R+8gb4gcIXzD6AUhp9pAqyl2QAeIiburKXCi8lMX01w4B6Uh2z0xO8dwOL17CXLZbxqc v2RVzyHI+lkiBxEgWe43REQCuiZ5DlkffbZlGqDe3ulE5IRBSZwwE8t8L/qRcFr1gda8 eU8/ZuVAwX41zxcMIEUkbmZfhWKtLtBLPTfl/jYqWLh6yXsdY8hkPS/3xdlryUvOGNpr gMFCa3gWut4Omy3Jt7SHpVdNaTyzdwfiK3v+zGIzLPYBOr3m+a57wtizW1BfHiNxhnDq vAFw== X-Gm-Message-State: ACgBeo2YFg+q2GM126GYGUg+PM8Orq1cGhg/ZY1JwpM4VUC4jllfPXL5 nprIF01UNziHjjMRKzL95bbOWRSsUdwtiw== X-Google-Smtp-Source: AA6agR6z9LUNGwm1LnmkKQ/7/EjbPVHZgUIgnuJ6rrG2/NIpecHpPVO66VZ5CUbOGXH7j5Q96ZxxkA== X-Received: by 2002:a05:6512:159e:b0:498:f1eb:f7a with SMTP id bp30-20020a056512159e00b00498f1eb0f7amr358237lfb.425.1662632588959; Thu, 08 Sep 2022 03:23:08 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id q3-20020a056512210300b004946aef1814sm2276848lfr.137.2022.09.08.03.23.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Sep 2022 03:23:08 -0700 (PDT) Message-ID: <51d77893-502d-9581-5d50-e99ff0a730e6@linaro.org> Date: Thu, 8 Sep 2022 12:23:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH 3/3] regulator: dt-bindings: qcom,rpmh: Indicate regulator-allow-set-load dependencies Content-Language: en-US To: Andrew Halaney Cc: agross@kernel.org, andersson@kernel.org, konrad.dybcio@somainline.org, lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, dianders@chromium.org, johan@kernel.org References: <20220902185148.635292-1-ahalaney@redhat.com> <20220902185148.635292-4-ahalaney@redhat.com> <20220906144117.wyqulotg52aqru7u@halaneylaptop> From: Krzysztof Kozlowski In-Reply-To: <20220906144117.wyqulotg52aqru7u@halaneylaptop> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 06/09/2022 16:41, Andrew Halaney wrote: > On Mon, Sep 05, 2022 at 06:50:02PM +0200, Krzysztof Kozlowski wrote: >> On 02/09/2022 20:51, Andrew Halaney wrote: >>> For RPMH regulators it doesn't make sense to indicate >>> regulator-allow-set-load without saying what modes you can switch to, >>> so be sure to indicate a dependency on regulator-allowed-modes. >> >> Hmmmm.... What about other regulators? >> > > My understanding (which very well might be wrong) is that if your > regulator is allowed to change modes, and sets regulator-allow-set-load, > then you have to describe what modes you can switch to. >> But if you don't allow setting modes (for example qcom_rpm-regulator.c) > and just allow yourself to set_load() directly, then you don't need it. > > So there is a more general requirement that applies regulator wide, but > I'm not sure how you would apply that at a higher level. I don't see a > good way to figure out in dt-binding land what regulator ops each > binding supports. The bindings don't express it, but the regulator core explicitly asks for set_mode with set_load callbacks in drms_uA_update(), which depends on REGULATOR_CHANGE_DRMS (toggled with regulator-allow-set-load). drms_uA_update() later calls regulator_mode_constrain() which checks if mode changing is allowed (REGULATOR_CHANGE_MODE). Therefore based on current implementation and meaning of set-load/allowed-modes properties, I would say that this applies to all regulators. I don't think that RPMh is special here. Best regards, Krzysztof