From: Krzysztof Kozlowski <krzk@kernel.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Niklas Cassel <cassel@kernel.org>
Cc: "Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Abraham I" <kishon@kernel.org>,
dlemoal@kernel.org, linux-pci@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: PCI: pci-ep: Add ref-clk-mode
Date: Wed, 30 Apr 2025 09:18:06 +0200 [thread overview]
Message-ID: <51fa853a-61d6-4c8f-8636-80cce90d0a94@kernel.org> (raw)
In-Reply-To: <7xtp5i3jhntfev35uotcunur3qvcgq4vmcnkjde5eivajdbiqt@n2wsivrsr2dk>
On 30/04/2025 09:05, Manivannan Sadhasivam wrote:
>> Some device tree bindings have already implemented vendor specific
>> properties to handle this, e.g. "nvidia,enable-ext-refclk" (Common Clock)
>> and "nvidia,enable-srns" (SRNS). However, since this property is common
>> for all PCI controllers running in endpoint mode, this really ought to be
>> a property in the common pcie-ep.yaml device tree binding.
>>
>
> We should also mark the nvidia specific properties deprecated and use this one.
> But that's for another follow up series.
There should be an user of this property in this patchset (or linked
somehow), otherwise why do we need new binding?
Best regards,
Krzysztof
prev parent reply other threads:[~2025-04-30 7:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-25 9:20 [PATCH] dt-bindings: PCI: pci-ep: Add ref-clk-mode Niklas Cassel
2025-04-30 7:05 ` Manivannan Sadhasivam
2025-04-30 7:16 ` Niklas Cassel
2025-04-30 7:53 ` Manivannan Sadhasivam
2025-05-09 18:18 ` Rob Herring
2025-05-09 19:31 ` Manivannan Sadhasivam
2025-05-10 11:04 ` Niklas Cassel
2025-05-12 13:59 ` Rob Herring
2025-05-13 17:25 ` Niklas Cassel
2025-05-14 6:51 ` Niklas Cassel
2025-05-19 14:56 ` Rob Herring
2025-04-30 7:18 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51fa853a-61d6-4c8f-8636-80cce90d0a94@kernel.org \
--to=krzk@kernel.org \
--cc=bhelgaas@google.com \
--cc=cassel@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlemoal@kernel.org \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).