Re: [PATCH v2 2/3] arm64: dts: renesas: r8a77960: Add GX6250 GPU node

[Marek Vasut <marek.vasut@mailbox.org>]

On 10/16/25 10:22 AM, Geert Uytterhoeven wrote:

Hello Geert,

>> --- a/arch/arm64/boot/dts/renesas/r8a77960.dtsi
>> +++ b/arch/arm64/boot/dts/renesas/r8a77960.dtsi
>> @@ -2575,6 +2575,22 @@ gic: interrupt-controller@f1010000 {
>>                          resets = <&cpg 408>;
>>                  };
>>
>> +               gpu: gpu@fd000000 {
>> +                       compatible = "renesas,r8a7796-gpu",
>> +                                    "img,img-gx6250",
>> +                                    "img,img-rogue";
>> +                       reg = <0 0xfd000000 0 0x40000>;
>> +                       interrupts = <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>;
>> +                       clocks = <&cpg CPG_CORE R8A7796_CLK_ZG>,
>> +                                <&cpg CPG_CORE R8A7796_CLK_S2D1>,
>> +                                <&cpg CPG_MOD 112>;
>> +                       clock-names = "core", "mem", "sys";
>> +                       power-domains = <&sysc R8A7796_PD_3DG_A>,
>> +                                       <&sysc R8A7796_PD_3DG_B>;
>> +                       power-domain-names = "a", "b";
>> +                       resets = <&cpg 112>;
> 
> status = "disabled"; ?

The GPU is always present in the SoC, similar to IPMMU/GIC/DMA/VSP/... 
which are also never disabled, do we want to disable the GPU by default 
and enable per-board ?

I would argue the GPU should be enabled by default, so the GPU driver 
can do a proper power management of the GPU. If firmware is missing, at 
least power it off on failed probe, if nothing else.

[...]