* [PATCH V2 1/2] DT: Add documentation for ralink-wdt
@ 2013-08-08 9:41 John Crispin
2013-08-08 12:42 ` Guenter Roeck
2013-08-08 15:55 ` Kumar Gala
0 siblings, 2 replies; 5+ messages in thread
From: John Crispin @ 2013-08-08 9:41 UTC (permalink / raw)
To: Wim Van Sebroeck; +Cc: John Crispin, linux-watchdog, linux-mips, devicetree
Describe ralink-wdt binding.
Signed-off-by: John Crispin <blogic@openwrt.org>
Cc: linux-watchdog@vger.kernel.org
Cc: linux-mips@linux-mips.org
Cc: devicetree@vger.kernel.org
---
V1 used the old devicetree list as Cc.
.../devicetree/bindings/watchdog/ralink-wdt.txt | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
create mode 100644 Documentation/devicetree/bindings/watchdog/ralink-wdt.txt
diff --git a/Documentation/devicetree/bindings/watchdog/ralink-wdt.txt b/Documentation/devicetree/bindings/watchdog/ralink-wdt.txt
new file mode 100644
index 0000000..a70f0e8
--- /dev/null
+++ b/Documentation/devicetree/bindings/watchdog/ralink-wdt.txt
@@ -0,0 +1,19 @@
+Ralink Watchdog Timers
+
+Required properties :
+- compatible: must be "ralink,rt2880-wdt"
+- reg: physical base address of the controller and length of the register range
+
+Optional properties :
+- interrupt-parent: phandle to the INTC device node
+- interrupts : Specify the INTC interrupt number
+
+Example:
+
+ watchdog@120 {
+ compatible = "ralink,mt7620a-wdt", "ralink,rt2880-wdt";
+ reg = <0x120 0x10>;
+
+ interrupt-parent = <&intc>;
+ interrupts = <1>;
+ };
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH V2 1/2] DT: Add documentation for ralink-wdt
2013-08-08 9:41 [PATCH V2 1/2] DT: Add documentation for ralink-wdt John Crispin
@ 2013-08-08 12:42 ` Guenter Roeck
2013-08-08 12:55 ` John Crispin
2013-08-08 15:55 ` Kumar Gala
1 sibling, 1 reply; 5+ messages in thread
From: Guenter Roeck @ 2013-08-08 12:42 UTC (permalink / raw)
To: John Crispin; +Cc: Wim Van Sebroeck, linux-watchdog, linux-mips, devicetree
On 08/08/2013 02:41 AM, John Crispin wrote:
> Describe ralink-wdt binding.
>
> Signed-off-by: John Crispin <blogic@openwrt.org>
> Cc: linux-watchdog@vger.kernel.org
> Cc: linux-mips@linux-mips.org
> Cc: devicetree@vger.kernel.org
> ---
> V1 used the old devicetree list as Cc.
>
> .../devicetree/bindings/watchdog/ralink-wdt.txt | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/watchdog/ralink-wdt.txt
>
> diff --git a/Documentation/devicetree/bindings/watchdog/ralink-wdt.txt b/Documentation/devicetree/bindings/watchdog/ralink-wdt.txt
> new file mode 100644
> index 0000000..a70f0e8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/ralink-wdt.txt
> @@ -0,0 +1,19 @@
> +Ralink Watchdog Timers
> +
> +Required properties :
> +- compatible: must be "ralink,rt2880-wdt"
> +- reg: physical base address of the controller and length of the register range
> +
> +Optional properties :
> +- interrupt-parent: phandle to the INTC device node
> +- interrupts : Specify the INTC interrupt number
> +
> +Example:
> +
> + watchdog@120 {
> + compatible = "ralink,mt7620a-wdt", "ralink,rt2880-wdt";
Just wondering ... what is the "ralink,mt7620a-wdt" supposed to be used for ?
Thanks,
Guenter
> + reg = <0x120 0x10>;
> +
> + interrupt-parent = <&intc>;
> + interrupts = <1>;
> + };
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH V2 1/2] DT: Add documentation for ralink-wdt
2013-08-08 12:42 ` Guenter Roeck
@ 2013-08-08 12:55 ` John Crispin
2013-08-08 15:50 ` Guenter Roeck
0 siblings, 1 reply; 5+ messages in thread
From: John Crispin @ 2013-08-08 12:55 UTC (permalink / raw)
To: Guenter Roeck; +Cc: Wim Van Sebroeck, linux-watchdog, linux-mips, devicetree
On 08/08/13 14:42, Guenter Roeck wrote:
> On 08/08/2013 02:41 AM, John Crispin wrote:
>> Describe ralink-wdt binding.
>>
>> Signed-off-by: John Crispin <blogic@openwrt.org>
>> Cc: linux-watchdog@vger.kernel.org
>> Cc: linux-mips@linux-mips.org
>> Cc: devicetree@vger.kernel.org
>> ---
>> V1 used the old devicetree list as Cc.
>>
>> .../devicetree/bindings/watchdog/ralink-wdt.txt | 19
>> +++++++++++++++++++
>> 1 file changed, 19 insertions(+)
>> create mode 100644
>> Documentation/devicetree/bindings/watchdog/ralink-wdt.txt
>>
>> diff --git
>> a/Documentation/devicetree/bindings/watchdog/ralink-wdt.txt
>> b/Documentation/devicetree/bindings/watchdog/ralink-wdt.txt
>> new file mode 100644
>> index 0000000..a70f0e8
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/watchdog/ralink-wdt.txt
>> @@ -0,0 +1,19 @@
>> +Ralink Watchdog Timers
>> +
>> +Required properties :
>> +- compatible: must be "ralink,rt2880-wdt"
>> +- reg: physical base address of the controller and length of the
>> register range
>> +
>> +Optional properties :
>> +- interrupt-parent: phandle to the INTC device node
>> +- interrupts : Specify the INTC interrupt number
>> +
>> +Example:
>> +
>> + watchdog@120 {
>> + compatible = "ralink,mt7620a-wdt", "ralink,rt2880-wdt";
>
> Just wondering ... what is the "ralink,mt7620a-wdt" supposed to be
> used for ?
Hi
i copied the example from the dtsi file of the mt7620a SoC. i can remove
it if you like.
John
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH V2 1/2] DT: Add documentation for ralink-wdt
2013-08-08 12:55 ` John Crispin
@ 2013-08-08 15:50 ` Guenter Roeck
0 siblings, 0 replies; 5+ messages in thread
From: Guenter Roeck @ 2013-08-08 15:50 UTC (permalink / raw)
To: John Crispin; +Cc: Wim Van Sebroeck, linux-watchdog, linux-mips, devicetree
On 08/08/2013 05:55 AM, John Crispin wrote:
> On 08/08/13 14:42, Guenter Roeck wrote:
>> On 08/08/2013 02:41 AM, John Crispin wrote:
>>> Describe ralink-wdt binding.
>>>
>>> Signed-off-by: John Crispin <blogic@openwrt.org>
>>> Cc: linux-watchdog@vger.kernel.org
>>> Cc: linux-mips@linux-mips.org
>>> Cc: devicetree@vger.kernel.org
>>> ---
>>> V1 used the old devicetree list as Cc.
>>>
>>> .../devicetree/bindings/watchdog/ralink-wdt.txt | 19 +++++++++++++++++++
>>> 1 file changed, 19 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/watchdog/ralink-wdt.txt
>>>
>>> diff --git a/Documentation/devicetree/bindings/watchdog/ralink-wdt.txt b/Documentation/devicetree/bindings/watchdog/ralink-wdt.txt
>>> new file mode 100644
>>> index 0000000..a70f0e8
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/watchdog/ralink-wdt.txt
>>> @@ -0,0 +1,19 @@
>>> +Ralink Watchdog Timers
>>> +
>>> +Required properties :
>>> +- compatible: must be "ralink,rt2880-wdt"
>>> +- reg: physical base address of the controller and length of the register range
>>> +
>>> +Optional properties :
>>> +- interrupt-parent: phandle to the INTC device node
>>> +- interrupts : Specify the INTC interrupt number
>>> +
>>> +Example:
>>> +
>>> + watchdog@120 {
>>> + compatible = "ralink,mt7620a-wdt", "ralink,rt2880-wdt";
>>
>> Just wondering ... what is the "ralink,mt7620a-wdt" supposed to be used for ?
>
> Hi
>
> i copied the example from the dtsi file of the mt7620a SoC. i can remove it if you like.
>
Unless I am missing something, it is not a valid binding for this driver/device, so it should be removed.
Guenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH V2 1/2] DT: Add documentation for ralink-wdt
2013-08-08 9:41 [PATCH V2 1/2] DT: Add documentation for ralink-wdt John Crispin
2013-08-08 12:42 ` Guenter Roeck
@ 2013-08-08 15:55 ` Kumar Gala
1 sibling, 0 replies; 5+ messages in thread
From: Kumar Gala @ 2013-08-08 15:55 UTC (permalink / raw)
To: John Crispin; +Cc: Wim Van Sebroeck, linux-watchdog, linux-mips, devicetree
On Aug 8, 2013, at 4:41 AM, John Crispin wrote:
> Describe ralink-wdt binding.
>
> Signed-off-by: John Crispin <blogic@openwrt.org>
> Cc: linux-watchdog@vger.kernel.org
> Cc: linux-mips@linux-mips.org
> Cc: devicetree@vger.kernel.org
> ---
> V1 used the old devicetree list as Cc.
>
> .../devicetree/bindings/watchdog/ralink-wdt.txt | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/watchdog/ralink-wdt.txt
>
> diff --git a/Documentation/devicetree/bindings/watchdog/ralink-wdt.txt b/Documentation/devicetree/bindings/watchdog/ralink-wdt.txt
> new file mode 100644
> index 0000000..a70f0e8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/ralink-wdt.txt
Seems like this should be ralink-rt2880-wdt.txt (I'm guessing there are other ralink watchdog timers).
> @@ -0,0 +1,19 @@
> +Ralink Watchdog Timers
Should probably be Ralink RT2880 Watchdog Timer
> +
> +Required properties :
> +- compatible: must be "ralink,rt2880-wdt"
> +- reg: physical base address of the controller and length of the register range
> +
> +Optional properties :
> +- interrupt-parent: phandle to the INTC device node
> +- interrupts : Specify the INTC interrupt number
Since you'll be updating this to drop 'ralink,mt7620a-wdt' how about cleaning up the whitespace around ' :'
> +
> +Example:
> +
> + watchdog@120 {
> + compatible = "ralink,mt7620a-wdt", "ralink,rt2880-wdt";
> + reg = <0x120 0x10>;
> +
> + interrupt-parent = <&intc>;
> + interrupts = <1>;
> + };
> --
> 1.7.10.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
- k
--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-08-08 15:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-08 9:41 [PATCH V2 1/2] DT: Add documentation for ralink-wdt John Crispin
2013-08-08 12:42 ` Guenter Roeck
2013-08-08 12:55 ` John Crispin
2013-08-08 15:50 ` Guenter Roeck
2013-08-08 15:55 ` Kumar Gala
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).