From: Guenter Roeck <linux@roeck-us.net>
To: John Crispin <blogic@openwrt.org>
Cc: Wim Van Sebroeck <wim@iguana.be>,
linux-watchdog@vger.kernel.org, linux-mips@linux-mips.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH V2 1/2] DT: Add documentation for ralink-wdt
Date: Thu, 08 Aug 2013 08:50:16 -0700 [thread overview]
Message-ID: <5203BE38.9020902@roeck-us.net> (raw)
In-Reply-To: <52039551.9090006@openwrt.org>
On 08/08/2013 05:55 AM, John Crispin wrote:
> On 08/08/13 14:42, Guenter Roeck wrote:
>> On 08/08/2013 02:41 AM, John Crispin wrote:
>>> Describe ralink-wdt binding.
>>>
>>> Signed-off-by: John Crispin <blogic@openwrt.org>
>>> Cc: linux-watchdog@vger.kernel.org
>>> Cc: linux-mips@linux-mips.org
>>> Cc: devicetree@vger.kernel.org
>>> ---
>>> V1 used the old devicetree list as Cc.
>>>
>>> .../devicetree/bindings/watchdog/ralink-wdt.txt | 19 +++++++++++++++++++
>>> 1 file changed, 19 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/watchdog/ralink-wdt.txt
>>>
>>> diff --git a/Documentation/devicetree/bindings/watchdog/ralink-wdt.txt b/Documentation/devicetree/bindings/watchdog/ralink-wdt.txt
>>> new file mode 100644
>>> index 0000000..a70f0e8
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/watchdog/ralink-wdt.txt
>>> @@ -0,0 +1,19 @@
>>> +Ralink Watchdog Timers
>>> +
>>> +Required properties :
>>> +- compatible: must be "ralink,rt2880-wdt"
>>> +- reg: physical base address of the controller and length of the register range
>>> +
>>> +Optional properties :
>>> +- interrupt-parent: phandle to the INTC device node
>>> +- interrupts : Specify the INTC interrupt number
>>> +
>>> +Example:
>>> +
>>> + watchdog@120 {
>>> + compatible = "ralink,mt7620a-wdt", "ralink,rt2880-wdt";
>>
>> Just wondering ... what is the "ralink,mt7620a-wdt" supposed to be used for ?
>
> Hi
>
> i copied the example from the dtsi file of the mt7620a SoC. i can remove it if you like.
>
Unless I am missing something, it is not a valid binding for this driver/device, so it should be removed.
Guenter
next prev parent reply other threads:[~2013-08-08 15:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-08 9:41 [PATCH V2 1/2] DT: Add documentation for ralink-wdt John Crispin
2013-08-08 12:42 ` Guenter Roeck
2013-08-08 12:55 ` John Crispin
2013-08-08 15:50 ` Guenter Roeck [this message]
2013-08-08 15:55 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5203BE38.9020902@roeck-us.net \
--to=linux@roeck-us.net \
--cc=blogic@openwrt.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).