devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Laxman Dewangan <ldewangan@nvidia.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"grant.likely@linaro.org" <grant.likely@linaro.org>,
	"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
	"rob@landley.net" <rob@landley.net>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"rtc-linux@googlegroups.com" <rtc-linux@googlegroups.com>,
	"gg@slimlogic.co.uk" <gg@slimlogic.co.uk>,
	"kishon@ti.com" <kishon@ti.com>,
	Stephen Warren <swarren@nvidia.com>,
	Pawel Moll <Pawel.Moll@arm.com>,
	"ian.campbell@citrix.com" <ian.campbell@citrix.com>,
	"broonie@kernel.org" <broonie@kernel.org>
Subject: Re: [PATCH V4] drivers/rtc/rtc-palmas.c: support for backup battery charging
Date: Thu, 8 Aug 2013 22:47:50 +0530	[thread overview]
Message-ID: <5203D2BE.1010807@nvidia.com> (raw)
In-Reply-To: <20130808093340.GG14648@e106331-lin.cambridge.arm.com>

On Thursday 08 August 2013 03:03 PM, Mark Rutland wrote:
> On Wed, Aug 07, 2013 at 07:46:11PM +0100, Laxman Dewangan wrote:
>>> What happens if we charge at the wrong current?
>> Not much sure but I think it can create battery damage.
> If we charge a battery supporting >100mA at a current <100mA, will that
> cause damage? Or only if we charge above it's supported current?

Over-current charging can only damage. Lower charging current will not 
damage, just will take more time to charge.

>
> If the latter's true, it might make sense to invert the condition and
> describe that the battery may be charged at a higher current, with the
> default being <100mA. That way a missing property in the dt will only
> result in sub-optimal charging rather than battery damage.
>
Ok, fine with this. In this case property will be 
"ti,backup-battery-charge-high-current".



      reply	other threads:[~2013-08-08 17:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-07 10:29 [PATCH V4] drivers/rtc/rtc-palmas.c: support for backup battery charging Laxman Dewangan
2013-08-07 16:38 ` Mark Rutland
2013-08-07 18:46   ` Laxman Dewangan
2013-08-08  9:33     ` Mark Rutland
2013-08-08 17:17       ` Laxman Dewangan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5203D2BE.1010807@nvidia.com \
    --to=ldewangan@nvidia.com \
    --cc=Pawel.Moll@arm.com \
    --cc=akpm@linux-foundation.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gg@slimlogic.co.uk \
    --cc=grant.likely@linaro.org \
    --cc=ian.campbell@citrix.com \
    --cc=kishon@ti.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=rob.herring@calxeda.com \
    --cc=rob@landley.net \
    --cc=rtc-linux@googlegroups.com \
    --cc=swarren@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).