From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: Sean Paul <seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Cc: milo.kim-l0cyMroinI0@public.gmane.org,
cooloney-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
"Stéphane Marchesin"
<marcheu-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
"Aaron Durbin" <adurbin-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Subject: Re: [PATCH v2 2/2] backlight/lp855x: Add supply regulator to lp855x
Date: Wed, 03 Dec 2014 15:11:49 +0100 [thread overview]
Message-ID: <5204192.bzM5jPIgHv@wuerfel> (raw)
In-Reply-To: <1417570752-23633-2-git-send-email-seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
On Tuesday 02 December 2014 17:39:12 Sean Paul wrote:
>
> .../devicetree/bindings/video/backlight/lp855x.txt | 2 ++
> drivers/video/backlight/lp855x_bl.c | 18 ++++++++++++++++++
> include/linux/platform_data/lp855x.h | 2 ++
> 3 files changed, 22 insertions(+)
While your two patches are both correct (and applied already), I took
a look at the platform_data header and noticed that all users of this
file have been converted to DT a while ago, so it would be nice to clean
it up by integrating the linux/platform_data/lp855x.h header file into the
drivers/video/backlight/lp855x_bl.c itself.
You can then merge struct lp855x_platform_data into lp855x to avoid the
extra dynamic allocation and remove all the 'pdata' references in the
driver.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-12-03 14:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-03 1:39 [PATCH v2 1/2] backlight/lp855x: Refactor dt parsing code Sean Paul
[not found] ` <1417570752-23633-1-git-send-email-seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2014-12-03 1:39 ` [PATCH v2 2/2] backlight/lp855x: Add supply regulator to lp855x Sean Paul
[not found] ` <1417570752-23633-2-git-send-email-seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2014-12-03 1:57 ` Kim, Milo
2014-12-03 2:06 ` Jingoo Han
2014-12-03 2:13 ` Bryan Wu
2014-12-03 10:15 ` Lee Jones
2014-12-03 14:11 ` Arnd Bergmann [this message]
2014-12-03 17:28 ` Sean Paul
2014-12-09 3:03 ` Kim, Milo
[not found] ` <54866695.3050307-l0cyMroinI0@public.gmane.org>
2014-12-09 3:46 ` Jingoo Han
[not found] ` <000a01d01362$aee684d0$0cb38e70$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-12-09 8:13 ` Arnd Bergmann
2014-12-03 1:49 ` [PATCH v2 1/2] backlight/lp855x: Refactor dt parsing code Bryan Wu
2014-12-03 1:56 ` Kim, Milo
2014-12-03 2:08 ` Jingoo Han
2014-12-03 10:15 ` Lee Jones
-- strict thread matches above, loose matches on Subject: below --
2014-11-27 1:32 [PATCH 2/2] backlight/lp855x: Add supply regulator to lp855x Kim, Milo
[not found] ` <54767F43.2060901-l0cyMroinI0@public.gmane.org>
2014-12-01 21:07 ` [PATCH v2 " Sean Paul
[not found] ` <1417468079-4990-1-git-send-email-seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2014-12-03 0:54 ` Kim, Milo
[not found] ` <547E5F5C.40406-l0cyMroinI0@public.gmane.org>
2014-12-03 1:01 ` Sean Paul
[not found] ` <CAOw6vbLB=3An9+Juda=5Yx1vnuCgDsp=ucKNQ3B6AtiLv=FLYg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-12-03 1:15 ` Kim, Milo
[not found] ` <547E643A.7070202-l0cyMroinI0@public.gmane.org>
2014-12-03 1:33 ` Bryan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5204192.bzM5jPIgHv@wuerfel \
--to=arnd-r2ngtmty4d4@public.gmane.org \
--cc=adurbin-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=cooloney-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=marcheu-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=milo.kim-l0cyMroinI0@public.gmane.org \
--cc=seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox