From: Nishanth Menon <nm@ti.com>
To: Bill Huang <bilhuang@nvidia.com>
Cc: Lee Jones <lee.jones@linaro.org>,
"sameo@linux.intel.com" <sameo@linux.intel.com>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
"pawel.moll@arm.com" <pawel.moll@arm.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"swarren@wwwdotorg.org" <swarren@wwwdotorg.org>,
"ian.campbell@citrix.com" <ian.campbell@citrix.com>,
"rob@landley.net" <rob@landley.net>,
"broonie@linaro.org" <broonie@linaro.org>,
"j-keerthy@ti.com" <j-keerthy@ti.com>,
"grant.likely@linaro.org" <grant.likely@linaro.org>,
"ian@slimlogic.co.uk" <ian@slimlogic.co.uk>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Mallikarjun Kasoju <mkasoju@nvidia.com>
Subject: Re: [PATCH RESEND v2 1/1] mfd: palmas: Add power off control
Date: Fri, 9 Aug 2013 09:47:14 -0500 [thread overview]
Message-ID: <520500F2.2000200@ti.com> (raw)
In-Reply-To: <1376053269.20259.34.camel@bilhuang-vm1>
On 08/09/2013 08:01 AM, Bill Huang wrote:
> On Thu, 2013-08-08 at 20:32 +0800, Lee Jones wrote:
>> On Thu, 08 Aug 2013, Bill Huang wrote:
>>
>>> Hook up "pm_power_off" to palmas power off routine if there is DT
>>> property "ti,system-power-controller" defined, so platform which is
>>> powered by this regulator can be powered off properly.
>>>
>>> Signed-off-by: Mallikarjun Kasoju <mkasoju@nvidia.com>
>>> Signed-off-by: Bill Huang <bilhuang@nvidia.com>
>>> ---
>>> .../devicetree/bindings/regulator/palmas-pmic.txt | 5 +++
>>> drivers/mfd/palmas.c | 33 ++++++++++++++++++--
>>> include/linux/mfd/palmas.h | 1 +
>>> 3 files changed, 37 insertions(+), 2 deletions(-)
>>
>> Was a clear conclusion reached between Nishanth and yourself?
>>
>> As he has strong opinions on this I'd ideally like his Ack before
>> applying the patch.
>>
> Feel free to NACK if you are feeling this can't fit what you would like
> to add, then I'll pass the ball to you for implementing Palmas power off
> since you have already wrote part of the driver (with USB IRQ unmask?).
Apologies on the delay in review. As long as we are ok with not having a
drivers/power/reset driver, I can buy this as a step #1. USB IRQ unmask
could go on top of it.
Other than that,
Acked-by: Nishanth Menon <nm@ti.com>
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2013-08-09 14:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-08 11:45 [PATCH RESEND v2 1/1] mfd: palmas: Add power off control Bill Huang
2013-08-08 12:32 ` Lee Jones
2013-08-09 13:01 ` Bill Huang
2013-08-09 14:47 ` Nishanth Menon [this message]
2013-08-12 13:52 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520500F2.2000200@ti.com \
--to=nm@ti.com \
--cc=bilhuang@nvidia.com \
--cc=broonie@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=ian@slimlogic.co.uk \
--cc=j-keerthy@ti.com \
--cc=lee.jones@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mkasoju@nvidia.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=sameo@linux.intel.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).