From: Laxman Dewangan <ldewangan@nvidia.com>
To: Kumar Gala <galak@codeaurora.org>
Cc: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"grant.likely@linaro.org" <grant.likely@linaro.org>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
"rob@landley.net" <rob@landley.net>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"rtc-linux@googlegroups.com" <rtc-linux@googlegroups.com>,
"gg@slimlogic.co.uk" <gg@slimlogic.co.uk>,
"kishon@ti.com" <kishon@ti.com>,
Stephen Warren <swarren@nvidia.com>,
"pawel.moll@arm.com" <pawel.moll@arm.com>,
"Mark.Rutland@arm.com" <Mark.Rutland@arm.com>,
"ian.campbell@citrix.com" <ian.campbell@citrix.com>,
"broonie@kernel.org" <broonie@kernel.org>
Subject: Re: [PATCH] drivers/rtc/rtc-palmas.c: rename charging dt property name
Date: Fri, 9 Aug 2013 21:23:39 +0530 [thread overview]
Message-ID: <52051083.4070403@nvidia.com> (raw)
In-Reply-To: <105188C0-FD22-488B-B9D2-1E3C801616B6@codeaurora.org>
On Friday 09 August 2013 09:07 PM, Kumar Gala wrote:
> On Aug 9, 2013, at 10:47 AM, Laxman Dewangan wrote:
>
>> Renaming the charging property names to have more meaningful:
>>
>> Renaming property "ti,back-battery-charge-enable" to "ti,backup-battery-chargeable"
>> to tells OS that attahced battery is chargeable and OS can do charging.
>>
>> Renaming property "ti,back-battery-charge-low-current" to
>> "ti,backup-battery-charge-high-current" for safe configuration as maximum charging current
>> of battery depends on battery type and overcurrent charging can damage the battery. So
>> enable the high current charging only if this property is available.
>>
>> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
>> ---
>> The patch V4 version of the change
>> [PATCH V4] drivers/rtc/rtc-palmas.c: support for backup battery charging
>> is already applied but still the discussion is going on the property name.
>>
>> To correct the property name, I am sending this patch on top of above patch
>> as per discussion on above patch.
>>
>> .../devicetree/bindings/rtc/rtc-palmas.txt | 21 +++++++++++--------
>> drivers/rtc/rtc-palmas.c | 14 ++++++------
>> 2 files changed, 19 insertions(+), 16 deletions(-)
> Are you not concerned about any dts with the old property names being around such that the code should support the old name as well?
>
I introduced these properties on above patch and it applied yesterday
only. Hence no one is using now. So no issue here.
next prev parent reply other threads:[~2013-08-09 15:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-09 15:47 [PATCH] drivers/rtc/rtc-palmas.c: rename charging dt property name Laxman Dewangan
2013-08-09 15:37 ` Kumar Gala
2013-08-09 15:53 ` Laxman Dewangan [this message]
2013-08-09 15:41 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52051083.4070403@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=Mark.Rutland@arm.com \
--cc=akpm@linux-foundation.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gg@slimlogic.co.uk \
--cc=grant.likely@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=kishon@ti.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=rtc-linux@googlegroups.com \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox