From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ea0-f178.google.com ([209.85.215.178]:52585 "EHLO mail-ea0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031614Ab3HIXhK (ORCPT ); Fri, 9 Aug 2013 19:37:10 -0400 Message-ID: <52057D21.1010408@gmail.com> Date: Sat, 10 Aug 2013 01:37:05 +0200 From: Sylwester Nawrocki MIME-Version: 1.0 Subject: Re: [PATCH v4 12/13] V4L: s5k6a3: Change sensor min/max resolutions References: <1375866242-18084-1-git-send-email-arun.kk@samsung.com> <1375866242-18084-13-git-send-email-arun.kk@samsung.com> In-Reply-To: <1375866242-18084-13-git-send-email-arun.kk@samsung.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org To: Arun Kumar K Cc: linux-media@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, s.nawrocki@samsung.com, hverkuil@xs4all.nl, a.hajda@samsung.com, sachin.kamat@linaro.org, shaik.ameer@samsung.com, kilyeon.im@samsung.com, arunkk.samsung@gmail.com List-ID: On 08/07/2013 11:04 AM, Arun Kumar K wrote: > s5k6a3 sensor has actual pixel resolution of 1408x1402 against > the active resolution 1392x1392. The real resolution is needed > when raw sensor SRGB data is dumped to memory by fimc-lite. > > Signed-off-by: Arun Kumar K > --- > drivers/media/i2c/s5k6a3.c | 21 +++++++++++++-------- > 1 file changed, 13 insertions(+), 8 deletions(-) > > diff --git a/drivers/media/i2c/s5k6a3.c b/drivers/media/i2c/s5k6a3.c > index ccbb4fc..6dec2ec 100644 > --- a/drivers/media/i2c/s5k6a3.c > +++ b/drivers/media/i2c/s5k6a3.c > @@ -25,10 +25,14 @@ > #include > #include > > -#define S5K6A3_SENSOR_MAX_WIDTH 1392 > -#define S5K6A3_SENSOR_MAX_HEIGHT 1392 > -#define S5K6A3_SENSOR_MIN_WIDTH 32 > -#define S5K6A3_SENSOR_MIN_HEIGHT 32 > +#define S5K6A3_SENSOR_MAX_WIDTH 1408 > +#define S5K6A3_SENSOR_MAX_HEIGHT 1408 Don't you want this to be 1402 ? > + Empty line could be removed. > +#define S5K6A3_SENSOR_ACTIVE_WIDTH 1392 > +#define S5K6A3_SENSOR_ACTIVE_HEIGHT 1392 > + Ditto. > +#define S5K6A3_SENSOR_MIN_WIDTH (32 + 16) > +#define S5K6A3_SENSOR_MIN_HEIGHT (32 + 10) > > #define S5K6A3_DEF_PIX_WIDTH 1296 > #define S5K6A3_DEF_PIX_HEIGHT 732 > @@ -107,10 +111,11 @@ static void s5k6a3_try_format(struct v4l2_mbus_framefmt *mf) > > fmt = find_sensor_format(mf); > mf->code = fmt->code; > - v4l_bound_align_image(&mf->width, S5K6A3_SENSOR_MIN_WIDTH, > - S5K6A3_SENSOR_MAX_WIDTH, 0, > - &mf->height, S5K6A3_SENSOR_MIN_HEIGHT, > - S5K6A3_SENSOR_MAX_HEIGHT, 0, 0); > + v4l_bound_align_image(&mf->width, > + S5K6A3_SENSOR_MIN_WIDTH, S5K6A3_SENSOR_MAX_WIDTH, 0, > + &mf->height, > + S5K6A3_SENSOR_MIN_HEIGHT, S5K6A3_SENSOR_MAX_HEIGHT, 0, > + 0); > } > > static struct v4l2_mbus_framefmt *__s5k6a3_get_format( Reviewed-by: Sylwester Nawrocki -- Thanks, Sylwester