From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from avon.wwwdotorg.org ([70.85.31.133]:55757 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750980Ab3HLRnF (ORCPT ); Mon, 12 Aug 2013 13:43:05 -0400 Message-ID: <52091EA5.7070000@wwwdotorg.org> Date: Mon, 12 Aug 2013 11:43:01 -0600 From: Stephen Warren MIME-Version: 1.0 Subject: Re: [PATCH] pwm: renesas-tpu: Add DT support References: <1374791261-9850-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> In-Reply-To: <1374791261-9850-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org To: Laurent Pinchart Cc: linux-pwm@vger.kernel.org, linux-sh@vger.kernel.org, devicetree@vger.kernel.org, Ian Campbell , Mark Rutland , Pawel Moll , Rob Herring , Kumar Gala List-ID: On 07/25/2013 04:27 PM, Laurent Pinchart wrote: > Specify DT bindings for the TPU PWM controller and add OF support to the > driver. > diff --git a/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.txt b/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.txt > + - compatible: should be one of the following. > + - "renesas,tpu-r8a73a4": for R8A77A4 (R-Mobile APE6) compatible PWM controller. > + - "renesas,tpu-r8a7740": for R8A7740 (R-Mobile A1) compatible PWM controller. In the bindings I've seen, it's more typical for the compatible value to be ${vendor},${soc}-${unit} than ${vendor},${unit}-${soc}. I guess I don't know how common one format or the other is though. Other than that, the binding, Acked-by: Stephen Warren