devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: broonie@kernel.org, sameo@linux.intel.com,
	rob.herring@calxeda.com, pawel.moll@arm.com,
	mark.rutland@arm.com, rob@landley.net, lee.jones@linaro.org,
	grant.likely@linaro.org, devicetree@vger.kernel.org,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	gg@slimlogic.co.uk, kishon@ti.com, j-keerthy@ti.com,
	ian.campbell@citrix.com
Subject: Re: [PATCH V2 3/3] regulator: palmas: add support for external control of rails
Date: Tue, 13 Aug 2013 13:15:02 -0600	[thread overview]
Message-ID: <520A85B6.8060901@wwwdotorg.org> (raw)
In-Reply-To: <1376380392-19723-4-git-send-email-ldewangan@nvidia.com>

On 08/13/2013 01:53 AM, Laxman Dewangan wrote:
> Palmas rails like LDOs, SMPSs, REGENs, SYSENs can be enable and disable
> by register programming through I2C communication as well as it can be
> enable/disable with the external control input ENABLE1, ENABLE2 and NSLEEP.
> 
> Add support for configuring these rails to be controlled by external control
> inputs. This is require to configure the rail's control register as well as
> configuration of resource register.
> 
> Provide the external input names through parameter "roof-floor". Updated the
> DT binding document to details different value of the roof-floor.

Please see my comments on V1; I think the binding modification should be
backwards-compatible.

      reply	other threads:[~2013-08-13 19:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-13  7:53 [PATCH V2 0/3] regulator: palmas: add support for external control of rail Laxman Dewangan
2013-08-13  7:53 ` [PATCH V2 1/3] regulator: palmas: Update the DT binding doc for smps10 out1 and out2 Laxman Dewangan
2013-08-13 10:16   ` Mark Brown
2013-08-13 19:14   ` Stephen Warren
2013-08-13  7:53 ` [PATCH V2 2/3] mfd: palmas: add support for external control configuration Laxman Dewangan
2013-08-13 10:27   ` Lee Jones
2013-08-20  1:25   ` Samuel Ortiz
2013-08-13  7:53 ` [PATCH V2 3/3] regulator: palmas: add support for external control of rails Laxman Dewangan
2013-08-13 19:15   ` Stephen Warren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=520A85B6.8060901@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gg@slimlogic.co.uk \
    --cc=grant.likely@linaro.org \
    --cc=ian.campbell@citrix.com \
    --cc=j-keerthy@ti.com \
    --cc=kishon@ti.com \
    --cc=ldewangan@nvidia.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=rob.herring@calxeda.com \
    --cc=rob@landley.net \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).