From: Stephen Warren <swarren@wwwdotorg.org>
To: "Ivan T. Ivanov" <iivanov@mm-sol.com>
Cc: balbi@ti.com, rob.herring@calxeda.com, pawel.moll@arm.com,
mark.rutland@arm.com, ian.campbell@citrix.com, rob@landley.net,
gregkh@linuxfoundation.org, grant.likely@linaro.org,
idos@codeaurora.org, mgautam@codeaurora.org,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
linux-omap@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [RFC PATCH v2 1/3] usb: dwc3: msm: Add device tree binding information
Date: Tue, 13 Aug 2013 13:57:29 -0600 [thread overview]
Message-ID: <520A8FA9.2080603@wwwdotorg.org> (raw)
In-Reply-To: <1376042027-9798-2-git-send-email-iivanov@mm-sol.com>
On 08/09/2013 03:53 AM, Ivan T. Ivanov wrote:
> From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
>
> MSM USB3.0 core wrapper consist of USB3.0 IP (SNPS)
> and HS, SS PHY's controll and configuration registers.
s/controll/control/
> It could operate in device mode (SS, HS, FS) and host
> mode (SS, HS, FS, LS).
> diff --git a/Documentation/devicetree/bindings/usb/msm-ssusb.txt b/Documentation/devicetree/bindings/usb/msm-ssusb.txt
> +MSM SuperSpeed DWC3 USB SoC controller
> +
> +Required properities :
> +- compatible : sould be "qcom,dwc3-hsphy";
...
> +Required properities :
> +- compatible : sould be "qcom,dwc3-ssphy";
I would expect different compatible values to be documented in different
files.
> +Optional properties :
> +- gdsc-supply : phandle to the globally distributed switch controller
> + regulator node to the USB controller.
Which of the 3 compatible values that were described above is that
property optional for?
> +Sub nodes:
> +- Sub node for "DWC3 USB3 controller".
> + This sub node is required property for device node. The properties
> + of this subnode are specified in dwc3.txt.
Why not represent the PHY and USB controller as separate top-level
nodes? They can point at each-other with phandles if they need to know
each-others' identity.
next prev parent reply other threads:[~2013-08-13 19:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-09 9:53 [RFC PATCH v2 0/3] DWC3 USB support for Qualcomm platform Ivan T. Ivanov
2013-08-09 9:53 ` [RFC PATCH v2 1/3] usb: dwc3: msm: Add device tree binding information Ivan T. Ivanov
[not found] ` <169628C9-00BA-4E58-BF65-7B180E6BE4ED@codeaurora.org>
2013-08-12 18:04 ` Felipe Balbi
2013-08-12 18:49 ` Kumar Gala
2013-08-13 7:32 ` Ivan T. Ivanov
2013-08-13 7:21 ` Ivan T. Ivanov
2013-08-13 19:57 ` Stephen Warren [this message]
2013-08-14 7:18 ` Ivan T. Ivanov
2013-08-09 9:53 ` [RFC PATCH v2 2/3] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DWC3 core Ivan T. Ivanov
2013-08-09 9:53 ` [RFC PATCH v2 3/3] usb: dwc3: Add Qualcomm DWC3 glue layer driver Ivan T. Ivanov
2013-08-09 13:32 ` Felipe Balbi
2013-08-09 15:16 ` Ivan T. Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520A8FA9.2080603@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=balbi@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=ian.campbell@citrix.com \
--cc=idos@codeaurora.org \
--cc=iivanov@mm-sol.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mgautam@codeaurora.org \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).