From: Sekhar Nori <nsekhar-l0cyMroinI0@public.gmane.org>
To: "Manjunathappa, Prakash" <prakash.pm-l0cyMroinI0@public.gmane.org>
Cc: davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org,
linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org,
grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org,
linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
hs-ynQEQJNshbs@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v3 5/5] ARM: davinci: serial: platform code cleanup
Date: Wed, 14 Aug 2013 11:27:09 +0000 [thread overview]
Message-ID: <520B698D.60203@ti.com> (raw)
In-Reply-To: <51ED0534.2080408-l0cyMroinI0@public.gmane.org>
Hi Prakash,
On Monday 22 July 2013 10:11 AM, Sekhar Nori wrote:
> On Wednesday 19 June 2013 02:45 PM, Manjunathappa, Prakash wrote:
>> 1) "struct davinci_uart_config" is introduced to specify
>> UART ports brought out or enabled on the board. But
>> none of the boards use them for that purpose, so clean
>> it up.
>> 2) Have pointer to platform device as a argument for
>> davinci_serial_init(), no need of serial_dev in
>> struct soc_info now.
>> 3) No need of davinci_serial_setup_clk(), not called from
>> multiple places, hence reduce function call overhead.
>
> 1) and 2) are related but 3) can be moved into a different patch - this
> patch will otherwise be doing too many things (hint for that is a vague
> headline and too many items to list in description)
>
> Can you respin just this patch based on v3.12/soc branch of my tree?
Since I did not get a response to this and the window for v3.12 is
closing fast, I went ahead and did the split myself. Here is the result:
https://git.kernel.org/cgit/linux/kernel/git/nsekhar/linux-davinci.git/log/?h=v3.12/soc
Thanks,
Sekhar
prev parent reply other threads:[~2013-08-14 11:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-19 9:15 [PATCH v3 0/5] ARM: davinci: fix UART clock enabling Manjunathappa, Prakash
[not found] ` <1371633342-1210-1-git-send-email-prakash.pm-l0cyMroinI0@public.gmane.org>
2013-06-19 9:15 ` [PATCH v3 1/5] ARM: davinci: uart: move to devid based clk_get Manjunathappa, Prakash
[not found] ` <1371633342-1210-2-git-send-email-prakash.pm-l0cyMroinI0@public.gmane.org>
2013-07-19 13:06 ` Sekhar Nori
2013-06-19 9:15 ` [PATCH v3 2/5] ARM: davinci: da850: override device name of UART in DT kernel Manjunathappa, Prakash
[not found] ` <1371633342-1210-3-git-send-email-prakash.pm-l0cyMroinI0@public.gmane.org>
2013-07-19 14:50 ` Sekhar Nori
2013-06-19 9:15 ` [PATCH v3 3/5] ARM: davinci: da850: do not specify clock_frequency for UART DT node Manjunathappa, Prakash
[not found] ` <1371633342-1210-4-git-send-email-prakash.pm-l0cyMroinI0@public.gmane.org>
2013-07-22 10:03 ` Sekhar Nori
2013-06-19 9:15 ` [PATCH v3 4/5] ARM: davinci: da8xx: remove da8xx_uart_clk_enable Manjunathappa, Prakash
[not found] ` <1371633342-1210-5-git-send-email-prakash.pm-l0cyMroinI0@public.gmane.org>
2013-07-22 10:03 ` Sekhar Nori
2013-06-19 9:15 ` [PATCH v3 5/5] ARM: davinci: serial: platform code cleanup Manjunathappa, Prakash
[not found] ` <1371633342-1210-6-git-send-email-prakash.pm-l0cyMroinI0@public.gmane.org>
2013-07-22 10:11 ` Sekhar Nori
[not found] ` <51ED0534.2080408-l0cyMroinI0@public.gmane.org>
2013-08-14 11:27 ` Sekhar Nori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520B698D.60203@ti.com \
--to=nsekhar-l0cymroini0@public.gmane.org \
--cc=davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
--cc=hs-ynQEQJNshbs@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=prakash.pm-l0cyMroinI0@public.gmane.org \
--cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).