From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from avon.wwwdotorg.org ([70.85.31.133]:33899 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757097Ab3HQANI (ORCPT ); Fri, 16 Aug 2013 20:13:08 -0400 Message-ID: <520EADFC.5000607@wwwdotorg.org> Date: Fri, 16 Aug 2013 16:55:56 -0600 From: Stephen Warren MIME-Version: 1.0 Subject: Re: [PATCH v3] hwspinlock/msm: Add support for Qualcomm MSM HW Mutex block References: <1376507361-26907-1-git-send-email-galak@codeaurora.org> In-Reply-To: <1376507361-26907-1-git-send-email-galak@codeaurora.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org To: Kumar Gala Cc: ohad@wizery.com, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Grant Likely , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Jeffrey Hugo , Eric Holmberg List-ID: On 08/14/2013 01:09 PM, Kumar Gala wrote: > Add driver for Qualcomm MSM Hardware Mutex block that exists on newer MSM > SoC (MSM8974, etc). > diff --git a/Documentation/devicetree/bindings/hwlock/msm-tcsr-mutex.txt b/Documentation/devicetree/bindings/hwlock/msm-tcsr-mutex.txt > +Required properties: > +- compatible: should be "qcom,tcsr-mutex" > +- reg: Should contain registers location and length of mutex registers > +- reg-names: > + "mutex-base" - string to identify mutex registers > +- qcom,num-locks: the number of locks/mutexes supported Doesn't the block support any interrupts? I suppose the interrupts property can be optional though even if it does. Aside from the comments re: reg-names, this binding seems fine.