Re: [PATCH v6 4/4] phy: airoha: Add support for Airoha AN7581 USB PHY

[Krzysztof Kozlowski <krzk@kernel.org>]

On 07/03/2026 11:37, Christian Marangi wrote:
>>> +
>>> +		if (phy_type == PHY_TYPE_USB3) {
>>> +			ret = of_property_read_u32(dev->of_node, "airoha,usb3-serdes",
>>> +						   &priv->serdes_port);
>>> +			if (ret)
>>> +				return dev_err_probe(dev, ret, "missing serdes line for USB 3.0\n");
>>> +
>>> +			priv->scu = syscon_regmap_lookup_by_compatible("airoha,en7581-scu");
>>
>> Nope, you need phandle to express proper device links.
>>
>> Don't sprinkle compatible lookups for new code which does not need to
>> keep things backwards compatible. How do you manage device links
>> without phandle? How do you manage device probe ordering?
>>
> 
> Hi,
> 
> the phandle to SCU was present in old implementation but later dropped as it was
> said that it wouldn't describe the HW.


I went through v3 review and I did not find such said arguments. Can you
point me to it?


> 
> I will readd as airoha,scu. Is it ok for you?
> 
> (I actually prefer phandle than hardcoding compatible as it makes things more
> descriptive and prevent all kind of problem in the future, so I'm more than
> happy than using that)
> 


Best regards,
Krzysztof