Re: [PATCH 1/3] of: add vendor prefix for Mentor Graphics

Re: [PATCH 1/3] of: add vendor prefix for Mentor Graphics

[Stephen Warren]

On 08/17/2013 03:27 AM, Sebastian Andrzej Siewior wrote:
> On 08/17/2013 12:52 AM, Stephen Warren wrote:
>> On 08/15/2013 07:13 AM, Sebastian Andrzej Siewior wrote:
>>> This prefix is currently used for the musb driver.
>>
>>> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
>>
>>> +mg	Mentor Graphics
>>
>> It's slightly short; I would have preferred "mentor" I think. but I
>> guess it's fine.
>>
>> I see that both values are already used though:
>>
>>> arch/arm/boot/dts/am33xx.dtsi:375:					compatible = "mg,musbmhdrc";
>>> arch/arm/boot/dts/am33xx.dtsi:430:					compatible = "mg,musbmhdrc";
>>
>>> arch/arm/boot/dts/dbx5x0.dtsi:181:				"mentor,musb";
>>
>> Should both be documented? Should the bindings for those devices be
>> unified on one vendor prefix, with the old one perhaps still documented
>> as deprecated depending on how long it's been around?
> 
> I wasn't aware of the dbx5x0 mentor,usb binding. As far as the am33xx
> is concerned, it has been prepared for the next merge window and can be
> changed.

OK, changing it to mentor, seems simplest and most convenient then.

> However the mentor,usb binding isn't documented either.

Presumably you can just adjust this patch to document it.

Re: [PATCH 1/3] of: add vendor prefix for Mentor Graphics

[Sebastian Andrzej Siewior]

On 08/19/2013 05:50 PM, Stephen Warren wrote:
>>>> arch/arm/boot/dts/am33xx.dtsi:375:					compatible = "mg,musbmhdrc";
>>>> arch/arm/boot/dts/am33xx.dtsi:430:					compatible = "mg,musbmhdrc";
>>>
>>>> arch/arm/boot/dts/dbx5x0.dtsi:181:				"mentor,musb";
>>>
>>> Should both be documented? Should the bindings for those devices be
>>> unified on one vendor prefix, with the old one perhaps still documented
>>> as deprecated depending on how long it's been around?
>>
>> I wasn't aware of the dbx5x0 mentor,usb binding. As far as the am33xx
>> is concerned, it has been prepared for the next merge window and can be
>> changed.
> 
> OK, changing it to mentor, seems simplest and most convenient then.

Okay.

>> However the mentor,usb binding isn't documented either.
> 
> Presumably you can just adjust this patch to document it.

Okay. That means if we stick to that hierarchy given my dbx5x0 (which
makes sense after thinking for a while) I'm going to shift my devices a
little to fit this. Once this is done I document it and post patches.

Sebastian