From: Arnd Bergmann <arnd@arndb.de>
To: Alim Akhtar <alim.akhtar@samsung.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
JBottomley@odin.com, vinholikatti@gmail.com,
amit.daniel@samsung.com, essuuj@gmail.com,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3 11/13] Documentation: devicetree: ufs: Add DT bindings for exynos UFS host controller
Date: Tue, 13 Oct 2015 14:10:01 +0200 [thread overview]
Message-ID: <5214359.Szp3KsYW6e@wuerfel> (raw)
In-Reply-To: <561CECB2.2090208@samsung.com>
On Tuesday 13 October 2015 17:06:18 Alim Akhtar wrote:
> > Better rename them to "core", "ref" and "iface", no point requiring to
> > spell out "clk" here.
> >
> >> + ufs,pwr-attr-mode = "FAST";
> >
> > A string is rather unusual here, what are the allowed values? Could you
> > use a boolean property instead?
> >
> will update the binding, supported modes are FAST, SLOW, FAST_auto etc,
> so kept the string for more readability
>
> >> + ufs,pwr-attr-lane = /bits/ 8 <2>;
> >> + ufs,pwr-attr-gear = /bits/ 8 <2>;
> >
> > Why the "/bits/ 8" ?
> >
> I am using of_property_read_u8() to read 8 bit value from property.
>
I still think it would be better to stay with conventional methods here,
and change the code accordingly. You can easily use of_property_read_u32
for the last two properties.
Arnd
next prev parent reply other threads:[~2015-10-13 12:10 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-01 8:09 [PATCH v3 00/13] exynos-ufs: add support for Exynos Alim Akhtar
2015-10-01 8:09 ` [PATCH v3 01/13] Documentation: samsung-phy: Add dt bindings for UFS Alim Akhtar
2015-10-01 8:09 ` [PATCH v3 02/13] phy: exynos-ufs: add UFS PHY driver for EXYNOS SoC Alim Akhtar
[not found] ` <1443686970-28104-3-git-send-email-alim.akhtar-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-10-01 8:41 ` kbuild test robot
2015-10-01 8:41 ` [PATCH] phy: exynos-ufs: fix platform_no_drv_owner.cocci warnings kbuild test robot
2015-10-01 11:04 ` [PATCH v3 02/13] phy: exynos-ufs: add UFS PHY driver for EXYNOS SoC kbuild test robot
2015-10-01 11:04 ` [RFC PATCH] phy: exynos-ufs: exynos_ufs_phy_calibrate() can be static kbuild test robot
2015-10-13 11:38 ` Alim Akhtar
[not found] ` <561CED52.9010806-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-10-13 12:58 ` [kbuild-all] " Fengguang Wu
2015-10-13 14:02 ` Kishon Vijay Abraham I
2015-10-01 8:09 ` [PATCH v3 03/13] scsi: ufs: add quirk to contain unconformable utrd field Alim Akhtar
2015-10-01 8:09 ` [PATCH v3 04/13] scsi: ufs: add quirk to fix mishandling utrlclr/utmrlclr Alim Akhtar
2015-10-01 8:09 ` [PATCH v3 05/13] scsi: ufs: add quirk not to allow reset of interrupt aggregation Alim Akhtar
2015-10-01 8:09 ` [PATCH v3 06/13] scsi: ufs: add quirk to enable host controller without hce Alim Akhtar
[not found] ` <1443686970-28104-1-git-send-email-alim.akhtar-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-10-01 8:09 ` [PATCH v3 07/13] scsi: ufs: add specific callback for nexus type Alim Akhtar
2015-10-01 8:09 ` [PATCH v3 08/13] scsi: ufs: add add specific callback for hibern8 Alim Akhtar
2015-10-01 8:09 ` [PATCH v3 09/13] scsi: ufs: make ufshcd_config_pwr_mode of non-static func Alim Akhtar
2015-10-01 8:09 ` [PATCH v3 10/13] scsi: ufs: return value of pwr_change_notify Alim Akhtar
2015-10-01 8:09 ` [PATCH v3 11/13] Documentation: devicetree: ufs: Add DT bindings for exynos UFS host controller Alim Akhtar
2015-10-01 11:37 ` Arnd Bergmann
2015-10-13 11:36 ` Alim Akhtar
2015-10-13 12:10 ` Arnd Bergmann [this message]
2015-10-01 8:09 ` [PATCH v3 12/13] scsi: ufs-exynos: add UFS host support for Exynos SoCs Alim Akhtar
[not found] ` <1443686970-28104-13-git-send-email-alim.akhtar-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-10-01 12:12 ` Arnd Bergmann
2015-10-13 11:19 ` Alim Akhtar
[not found] ` <561CE8CB.9010102-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-10-13 11:38 ` Arnd Bergmann
2015-10-13 11:45 ` Alim Akhtar
2015-10-01 8:09 ` [PATCH v3 13/13] scsi: ufs: Add exynos ufs platform data Alim Akhtar
2015-10-01 10:04 ` kbuild test robot
[not found] ` <1443686970-28104-14-git-send-email-alim.akhtar-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-10-01 10:14 ` kbuild test robot
2015-10-01 10:46 ` kbuild test robot
[not found] ` <201510011845.GN7Kisc4%fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-10-01 11:29 ` Arnd Bergmann
2015-10-05 8:14 ` Alim Akhtar
2015-10-05 9:06 ` Arnd Bergmann
2015-10-05 14:11 ` Rob Herring
[not found] ` <CAL_JsqJWzqMkkMH8myFX1eeuV-U25Ri_nWhjj2mb3AWh5tzDZA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-10-05 14:47 ` Arnd Bergmann
2015-10-05 15:20 ` Alim Akhtar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5214359.Szp3KsYW6e@wuerfel \
--to=arnd@arndb.de \
--cc=JBottomley@odin.com \
--cc=alim.akhtar@samsung.com \
--cc=amit.daniel@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=essuuj@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=vinholikatti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).