Re: [PATCH 1/2] extcon: extcon-dra7xx: Add extcon driver for USB ID detection

[George Cherian <george.cherian@ti.com>]

On 8/21/2013 11:05 PM, Stephen Warren wrote:
> On 08/21/2013 07:06 AM, George Cherian wrote:
>> Hi Stephen,
>>
>> On 8/20/2013 10:23 PM, Stephen Warren wrote:
>>>>> ID pins are connected to pcf8575, and the pcf8575's interrupt line is
>>>>> inturn connected to
>>>>> gpio bank6 pin 11, we use this gpio interrupt to detect the ID pin
>>>> change.
>>> In that case, the PCF8575 node needs to be a GPIO controller and an IRQ
>>> controller, as does the driver for the PCF8575. This binding should have
>>> a single entry in the gpios property, and the driver can call
>>> gpio_to_irq() on that so it knows which IRQ to request.
>> You meant some thing like this?
>>
>>         pcf_usb: pcf8575@21 {
>>                  compatible = "ti,pcf8575";
>>                  reg = <0x21>;
>>                  gpio-controller;
>>                  #gpio-cells = <2>;
>>                  interrupt-parent = <&gpio6>;
>>                  interrupts = <11 2>;
>>                  interrupt-controller;
>>                  #interrupt-cells = <2>;
>>       };
>>
>>       usb_vid_gpio {
>>                  compatible = "ti,dra7xx-usb";
>>                  gpios = <&pcf_usb 1 0>;
>>       };
> Yes.
>
> Except that the compatible value for the usb_vid_gpio node still looks
> wrong, since I think that node isn't anything to do with any particular SoC.

Yes will fix that too in v2.


-- 
-George