devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: Rob Herring <robherring2@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Jacek Anaszewski <j.anaszewski@samsung.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	Jonathan Cameron <jic23@kernel.org>,
	"maxime.ripard@free-electrons.com"
	<maxime.ripard@free-electrons.com>,
	"lars@metafoo.de" <lars@metafoo.de>,
	"l.czerwinski@samsung.com" <l.czerwinski@samsung.com>,
	Pawel Moll <Pawel.Moll@arm.com>,
	"ian.campbell@citrix.com" <ian.campbell@citrix.com>,
	"s.nawrocki@samsung.com" <s.nawrocki@samsung.com>
Subject: Re: passing two interrupts two an I2C driver
Date: Thu, 22 Aug 2013 14:26:35 -0600	[thread overview]
Message-ID: <521673FB.3040904@wwwdotorg.org> (raw)
In-Reply-To: <52160802.2070201@gmail.com>

On 08/22/2013 06:45 AM, Rob Herring wrote:
> On 08/21/2013 03:54 AM, Mark Rutland wrote:
...
>> We should fix the binding documents to make clear which bindings require
>> their reg properties at fixed indexes, and those which allow for
>> arbitrarily ordered named reg entries. Named reg entries are really
>> useful for blocks with optional components, and given we have drivers
>> using them, they're already mandatory for some bindings.
> 
> No, we should fix the bindings that have arbitrarily ordered reg
> properties. There is no obvious reg examples of this that I see from a
> quick scan of dts files.
> 
> There is this questionable use of "empty" for interrupt-names:
> 
> arch/arm/boot/dts/imx23.dtsi:
> 	interrupts = <0 14 20 0
> 			13 13 13 13>;
> 	interrupt-names = "empty", "ssp0", "ssp1", "empty",
> 			"gpmi0", "gpmi1", "gpmi2", "gpmi3";
> 

Well, there's been an assertion that bindings that define an ordered
interrupts property shouldn't have a interrupt-names property, and
bindings that define interrupt-names entries explicitly don't require a
specific order of entries in the interrupts property.

I assume from your statement, you don't agree, and think that interrupts
must always be in a specific order, even if interrupt-names exists?

If so, that'd make interrupt-names at least a bit useless and at worst
horribly misleading, since people will assume it defines the order and
that the order can be arbitrary.

  reply	other threads:[~2013-08-22 20:26 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <520E3B8F.9010800@samsung.com>
     [not found] ` <520E7417.3090606@wwwdotorg.org>
2013-08-19  8:42   ` passing two interrupts two an I2C driver Mark Rutland
2013-08-19 16:09     ` Stephen Warren
2013-08-20  8:44       ` Mark Rutland
2013-08-20 16:25         ` Stephen Warren
2013-08-21  8:54           ` Mark Rutland
2013-08-22 12:45             ` Rob Herring
2013-08-22 20:26               ` Stephen Warren [this message]
2013-08-21 11:53     ` Jacek Anaszewski
2013-08-21 12:34       ` Pawel Moll
2013-08-21 12:37       ` Pawel Moll
2013-08-21 17:54         ` Mark Brown
2013-08-22  9:23           ` Pawel Moll
2013-08-22 11:26             ` Mark Brown
2013-08-22 11:44               ` Pawel Moll
2013-08-22 13:19                 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=521673FB.3040904@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=Pawel.Moll@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=ian.campbell@citrix.com \
    --cc=j.anaszewski@samsung.com \
    --cc=jic23@kernel.org \
    --cc=l.czerwinski@samsung.com \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=maxime.ripard@free-electrons.com \
    --cc=robherring2@gmail.com \
    --cc=s.nawrocki@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).