From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: John Crispin <blogic@openwrt.org>
Cc: Ralf Baechle <ralf@linux-mips.org>,
linux-mips@linux-mips.org, devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH 4/6] DT: MIPS: ralink: add RT2880 dts files
Date: Fri, 23 Aug 2013 22:34:13 +0400 [thread overview]
Message-ID: <5217AB25.3050106@cogentembedded.com> (raw)
In-Reply-To: <1365843026-11015-4-git-send-email-blogic@openwrt.org>
On 04/13/2013 12:50 PM, John Crispin wrote:
> Add a dtsi file for RT2880 SoC and a sample dts file.
You forgot to mention Kconfig entry...
> Signed-off-by: John Crispin <blogic@openwrt.org>
[...]
> diff --git a/arch/mips/ralink/dts/Makefile b/arch/mips/ralink/dts/Makefile
> index 1a69fb3..f635a01 100644
> --- a/arch/mips/ralink/dts/Makefile
> +++ b/arch/mips/ralink/dts/Makefile
> @@ -1 +1,2 @@
> +obj-$(CONFIG_DTB_RT2880_EVAL) := rt2880_eval.dtb.o
> obj-$(CONFIG_DTB_RT305X_EVAL) := rt3052_eval.dtb.o
> diff --git a/arch/mips/ralink/dts/rt2880.dtsi b/arch/mips/ralink/dts/rt2880.dtsi
> new file mode 100644
> index 0000000..182afde
> --- /dev/null
> +++ b/arch/mips/ralink/dts/rt2880.dtsi
> @@ -0,0 +1,58 @@
> +/ {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "ralink,rt2880-soc";
> +
> + cpus {
> + cpu@0 {
> + compatible = "mips,mips4KEc";
> + };
> + };
> +
> + cpuintc: cpuintc@0 {
According to ePAPR spec [1], the node name should be "interrupt-controller".
> + #address-cells = <0>;
> + #interrupt-cells = <1>;
> + interrupt-controller;
> + compatible = "mti,cpu-interrupt-controller";
So, it's "mips" or "mti"?
> + };
> +
> + palmbus@300000 {
> + compatible = "palmbus";
> + reg = <0x300000 0x200000>;
> + ranges = <0x0 0x300000 0x1FFFFF>;
> +
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> + sysc@0 {
Perhaps "system-controller" to be in the same vein with other correct
naming I'm saying about?
> + compatible = "ralink,rt2880-sysc";
> + reg = <0x0 0x100>;
> + };
> +
> + intc: intc@200 {
According to ePAPR spec [1], the node name should be "interrupt-controller".
> + compatible = "ralink,rt2880-intc";
> + reg = <0x200 0x100>;
> +
> + interrupt-controller;
> + #interrupt-cells = <1>;
> +
> + interrupt-parent = <&cpuintc>;
> + interrupts = <2>;
> + };
> +
> + memc@300 {
According to ePAPR spec [1], the node name should be "memory-controller".
> + compatible = "ralink,rt2880-memc";
> + reg = <0x300 0x100>;
> + };
> +
> + uartlite@c00 {
According to ePAPR spec [1], the node name should be "serial".
[...]
> diff --git a/arch/mips/ralink/dts/rt2880_eval.dts b/arch/mips/ralink/dts/rt2880_eval.dts
> new file mode 100644
> index 0000000..e967b43
> --- /dev/null
> +++ b/arch/mips/ralink/dts/rt2880_eval.dts
> @@ -0,0 +1,48 @@
> +/dts-v1/;
> +
> +/include/ "rt2880.dtsi"
> +
> +/ {
[...]
> + cfi@1f000000 {
According to ePAPR spec [1], the node name should be "flash".
[1] http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf
WBR, Sergei
next prev parent reply other threads:[~2013-08-23 18:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-13 8:50 [PATCH 1/6] DT: add vendor prefixes for Ralink John Crispin
2013-04-13 8:50 ` [PATCH 2/6] DT: add documentation for the Ralink MIPS SoCs John Crispin
2013-04-14 9:44 ` Gabor Juhos
2013-04-13 8:50 ` [PATCH 3/6] DT: MIPS: ralink: extend RT3050 dtsi and dts file John Crispin
2013-04-13 14:49 ` Sergei Shtylyov
2013-04-13 8:50 ` [PATCH 4/6] DT: MIPS: ralink: add RT2880 dts files John Crispin
[not found] ` <1365843026-11015-4-git-send-email-blogic-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
2013-04-14 9:53 ` Gabor Juhos
2013-08-23 18:34 ` Sergei Shtylyov [this message]
2013-08-23 18:37 ` Sergei Shtylyov
2013-08-23 18:44 ` David Daney
2013-04-13 8:50 ` [PATCH 5/6] DT: MIPS: ralink: add RT3883 " John Crispin
[not found] ` <1365843026-11015-5-git-send-email-blogic-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
2013-04-14 9:54 ` Gabor Juhos
2013-04-13 8:50 ` [PATCH 6/6] DT: MIPS: ralink: add MT7620 " John Crispin
2013-04-14 11:41 ` Gabor Juhos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5217AB25.3050106@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=blogic@openwrt.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).